Remove dependency of non partitioned TPCC run on file config/geopartitioned_workload.xml#119
Open
deeps1991 wants to merge 2 commits intoyugabyte:masterfrom
Open
Remove dependency of non partitioned TPCC run on file config/geopartitioned_workload.xml#119deeps1991 wants to merge 2 commits intoyugabyte:masterfrom
deeps1991 wants to merge 2 commits intoyugabyte:masterfrom
Conversation
config/geopartitioned_workload.xml. If the benchmark is run from a directory that does not have the above file, it causes the benchmark to fail with FileNotFoundException. Instead, if no file is specified as part of the command line options, the benchmark should just assume that geopartitioning is disabled. This patch introduces changes for the above fix. Tested by running TPCC --create for both nonpartitioned and partitioned setups with and without the file present.
hbhanawat
reviewed
Sep 3, 2021
| GeoPartitionedConfigFileOptions geopartitionedConfigOptions = new GeoPartitionedConfigFileOptions(geopartitionedConfigFile); | ||
| GeoPartitionPolicy geoPartitionPolicy = geopartitionedConfigOptions.getGeoPartitionPlacement(totalWarehousesAcrossShards, numWarehouses, startWarehouseIdForShard); | ||
|
|
||
| String geopartitionedConfigFile = options.getGeoPartitionedConfigFile().orElse(""); |
Contributor
There was a problem hiding this comment.
I think we should keep this code as is for the cases when the default file is available. We can rather do a file exists check for the geopartitionedConfigFile variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TPCCBenchmark assumes the presence of the file
config/geopartitioned_workload.xml. If the benchmark
is run from a directory that does not have the above file,
it causes the benchmark to fail with FileNotFoundException.
Instead, if no file is specified as part of the command line
options, the benchmark should just assume that geopartitioning
is disabled.
This patch introduces changes for the above fix.
Tested by running TPCC --create for both nonpartitioned and
partitioned setups with and without the file present.