Conversation
mbautin
approved these changes
Nov 1, 2022
mbautin
left a comment
There was a problem hiding this comment.
Please add a comment specifying why it is necessary to acquire this mutex (e.g. say what variable is guarded by what mutex) and also mention why there would be no deadlocks.
36c7749 to
a5305f0
Compare
OlegLoginov
requested changes
Nov 2, 2022
OlegLoginov
requested changes
Nov 2, 2022
OlegLoginov
approved these changes
Nov 2, 2022
OlegLoginov
left a comment
There was a problem hiding this comment.
LGTM. Please add/describe a TEST PLAN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is data race between
clear_and_update_backandupdate_partitions(observed via CppCassandraDriverTest_TestCreateUniqueIndexPartial)This PR adds lock in
clear_and_update_back.Also fixes another race :
schema_snapshot_version_ is converted to atomic int for dealing with the second race condition.