Conversation
|
|
||
| } | ||
|
|
||
| public Vehicle announceTheChampion() { |
There was a problem hiding this comment.
по сути это геттер, поэтому лучше и проще будет написать getChampion, обычно артикли (the) в неймингах не используются
|
|
||
|
|
||
| class Race { | ||
| public Vehicle theChampion; |
There was a problem hiding this comment.
Т.к. для переменной есть геттер, то лучше сделать её приватной
Comment on lines
+50
to
+51
| private String name; | ||
| private int maxSpeed; |
There was a problem hiding this comment.
Чтобы меньше кода писать можно геттеры удалить и сделать так:
Suggested change
| private String name; | |
| private int maxSpeed; | |
| public final String name; | |
| public final int maxSpeed; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
СРОЧНО!!!
Добрый день!
исправил замечание, теперь ПР сделан в рамках моего репозитория, с ветки dev в ветку master.
Спасибо за комментарий!
Огромная просьба!!!
Посмотрите, пожалуйста, данный ПР пораньше, я все еще надеюсь успеть сдать проект по 4 спринту завтра до 23:59.
Иначе у меня учеба превратится в тыкву)
Спасибо за понимание!