fix attributes-editor: allow modifying tablet cell bundle attribute for replicated tables

[lesf0]

Commit 2757be5 allows it to display "tablet cell bundle" attribute in attributes editor dialog. However, it does nothing on submit when this attribute is changed.

This PR addresses and fixes this issue.

Summary by Sourcery

Bug Fixes:

• Ensure dynamic replicated tables are treated like dynamic tables when applying in-memory-related attribute updates from the attributes editor.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Extends the attributes editor logic so that "tablet cell bundle" (and other in-memory-related attributes) are correctly applied not only to dynamic tables but also to dynamic replicated tables when submitting changes.

Sequence diagram for applying in_memory_mode to dynamic replicated tables

sequenceDiagram
    actor User
    participant UI as AttributesEditorUI
    participant Store as NavigationStore
    participant Action as navigationSetNodeAttributes

    User->>UI: Edit tablet cell bundle
    UI->>Store: submitAttributes(nodePath, updatedAttributes)
    Store->>Action: navigationSetNodeAttributes(nodePath, attrs, in_memory_mode)

    Action->>Action: type = ypath.getValue(attrs, /@type)
    Action->>Action: isDynamic = ypath.getValue(attrs, /@dynamic)
    Action->>Action: isDynTable = [table, replicated_table].includes(type) && isDynamic

    alt in_memory_mode defined and isDynTable
        Action->>Action: Object.assign(newAttrs, {in_memory_mode})
    else in_memory_mode undefined or not isDynTable
        Action-->>Action: Do not modify newAttrs.in_memory_mode
    end

    Action-->>Store: newAttrs with updated in_memory_mode
    Store-->>UI: Update UI state
    UI-->>User: Show updated attributes applied

Loading

Flow diagram for determining when to apply in_memory_mode

flowchart TD
    A[Start navigationSetNodeAttributes] --> B[Read type from attrs @type]
    B --> C[Read isDynamic from attrs @dynamic]
    C --> D{Is type table or replicated_table?}
    D -->|No| E[isDynTable = false]
    D -->|Yes| F[isDynTable = true]
    E --> G{Is in_memory_mode defined?}
    F --> G
    G -->|No| H[Do not change newAttrs in_memory_mode]
    G -->|Yes and isDynTable true| I[Assign in_memory_mode to newAttrs]
    H --> J[Continue with other attribute updates]
    I --> J
    J --> K[Finish navigationSetNodeAttributes]

Loading

File-Level Changes

Change	Details	Files
Treat replicated tables as dynamic tables for in-memory attribute handling in the attributes editor submit logic.	Adjust the isDynTable detection logic to consider both 'table' and 'replicated_table' types when combined with the dynamic flag Ensure that in_memory_mode and related attributes are assigned for dynamic replicated tables as they already are for dynamic tables	packages/ui/src/ui/store/actions/navigation/modals/attributes-editor.tsx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}