Support accessLogBasePath in UI helm-chart [YT-26725]#1416
Open
ilyaibraev wants to merge 1 commit intoytsaurus:mainfrom
Open
Support accessLogBasePath in UI helm-chart [YT-26725]#1416ilyaibraev wants to merge 1 commit intoytsaurus:mainfrom
ilyaibraev wants to merge 1 commit intoytsaurus:mainfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a new Helm value Sequence diagram for accessLogBasePath propagation from Helm values to UIsequenceDiagram
actor Developer
participant HelmValues
participant HelmTemplate as Helm_ConfigMap_template
participant K8sConfigMap as Kubernetes_ConfigMap
participant BrowserUI as UI_app_in_browser
Developer->>HelmValues: Set settings.accessLogBasePath in values.yaml
Developer->>HelmTemplate: Run helm template/install
HelmValues->>HelmTemplate: Provide settings.odinBaseUrl, directDownload,
HelmValues->>HelmTemplate: uploadTableExcelBaseUrl, exportTableBaseUrl,
HelmValues->>HelmTemplate: accessLogBasePath
HelmTemplate->>K8sConfigMap: Render config-map.yaml with common.js
K8sConfigMap-->>BrowserUI: Mount common.js into UI container
BrowserUI->>BrowserUI: Read uiSettings.accessLogBasePath from common.js
BrowserUI->>BrowserUI: Use accessLogBasePath to build access log URLs
Flow diagram for accessLogBasePath through Helm chart configurationflowchart TD
A_values["values.yaml settings.accessLogBasePath"] --> B_template["config-map.yaml template
uses .Values.settings.accessLogBasePath
in common.js module.exports.uiSettings"]
B_template --> C_render["Helm render/install
produces Kubernetes ConfigMap"]
C_render --> D_configmap["ConfigMap.data[common.js]
contains uiSettings.accessLogBasePath"]
D_configmap --> E_pod["UI Pod mounts ConfigMap
and serves common.js"]
E_pod --> F_browser["Browser UI loads common.js
and reads uiSettings.accessLogBasePath"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
New Features: