Skip to content

Support accessLogBasePath in UI helm-chart [YT-26725]#1416

Open
ilyaibraev wants to merge 1 commit intoytsaurus:mainfrom
ilyaibraev:members/ilyaibraev/support-accessLogBasePath-in-chart
Open

Support accessLogBasePath in UI helm-chart [YT-26725]#1416
ilyaibraev wants to merge 1 commit intoytsaurus:mainfrom
ilyaibraev:members/ilyaibraev/support-accessLogBasePath-in-chart

Conversation

@ilyaibraev
Copy link

@ilyaibraev ilyaibraev commented Jan 19, 2026

Summary by Sourcery

New Features:

  • Expose accessLogBasePath in the UI configuration map and values to allow configuring the access log base URL path.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 19, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a new Helm value settings.accessLogBasePath and wires it into the generated common.js UI configuration so the UI can read the access log base path at runtime, along with minor formatting cleanup in the Helm chart templates.

Sequence diagram for accessLogBasePath propagation from Helm values to UI

sequenceDiagram
    actor Developer
    participant HelmValues
    participant HelmTemplate as Helm_ConfigMap_template
    participant K8sConfigMap as Kubernetes_ConfigMap
    participant BrowserUI as UI_app_in_browser

    Developer->>HelmValues: Set settings.accessLogBasePath in values.yaml
    Developer->>HelmTemplate: Run helm template/install
    HelmValues->>HelmTemplate: Provide settings.odinBaseUrl, directDownload,
    HelmValues->>HelmTemplate: uploadTableExcelBaseUrl, exportTableBaseUrl,
    HelmValues->>HelmTemplate: accessLogBasePath
    HelmTemplate->>K8sConfigMap: Render config-map.yaml with common.js
    K8sConfigMap-->>BrowserUI: Mount common.js into UI container
    BrowserUI->>BrowserUI: Read uiSettings.accessLogBasePath from common.js
    BrowserUI->>BrowserUI: Use accessLogBasePath to build access log URLs
Loading

Flow diagram for accessLogBasePath through Helm chart configuration

flowchart TD
    A_values["values.yaml settings.accessLogBasePath"] --> B_template["config-map.yaml template
uses .Values.settings.accessLogBasePath
in common.js module.exports.uiSettings"]
    B_template --> C_render["Helm render/install
produces Kubernetes ConfigMap"]
    C_render --> D_configmap["ConfigMap.data[common.js]
contains uiSettings.accessLogBasePath"]
    D_configmap --> E_pod["UI Pod mounts ConfigMap
and serves common.js"]
    E_pod --> F_browser["Browser UI loads common.js
and reads uiSettings.accessLogBasePath"]
Loading

File-Level Changes

Change Details Files
Expose a new access log base path setting from Helm values into the UI configuration.
  • Extend ui-helm-chart values with a new settings.accessLogBasePath key defaulting to an empty string.
  • Inject settings.accessLogBasePath into the generated common.js uiSettings object so it is available to the UI at runtime.
  • Normalize spacing/formatting in the common.js template block and nearby YAML.
packages/ui-helm-chart/templates/config-map.yaml
packages/ui-helm-chart/values.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant