Add GitHub Action for code formatting checks in src/ggml-hsa

[Copilot]

Overview

This PR adds an automated GitHub Action workflow that enforces code formatting standards for the src/ggml-hsa directory. The workflow checks both Python and C++ files and provides detailed feedback when formatting issues are detected.

Changes

1. New GitHub Action Workflow (.github/workflows/format-check.yml)

Created a comprehensive workflow that:

• Triggers automatically on:

  • Pull requests that modify files in src/ggml-hsa/**
  • Pushes to the hsa-backend branch that modify files in src/ggml-hsa/**

• Python Formatting: Uses Black to check all Python files (.py) in src/ggml-hsa

• C++ Formatting: Uses clang-format-20 to check all C++ files (.cpp, .hpp, .h, .c) against the existing .clang-format style file in src/ggml-hsa/

• Key Behavior:

  • ✅ Only suggests changes via detailed diffs in GitHub Step Summary
  • ✅ Never modifies code automatically
  • ✅ Fails the check when formatting issues are detected
  • ✅ Provides clear, actionable instructions for developers to fix issues locally

2. Documentation (Updated src/ggml-hsa/README.md)

Added a new "Code Formatting" section that documents:

• Python formatting requirements and commands
• C++ formatting requirements and commands
• How the automated checks work
• Clear statement that changes are never applied automatically

Technical Details

The workflow uses clang-format-20 because the existing .clang-format file in src/ggml-hsa/ contains options (like AlignCaseArrows) that are only supported in version 20 or later.

Example Output

When formatting issues are detected, developers will see:

• A failed check with clear error messages
• Detailed diffs showing exactly what needs to change
• Instructions on how to fix the issues locally using black or clang-format-20

Example fix commands:

# Fix Python files
black src/ggml-hsa

# Fix C++ files
clang-format-20 -i --style=file:src/ggml-hsa/.clang-format <file>

Benefits

• 🎯 Enforces consistent code style automatically
• 📝 Clear documentation for contributors
• 🔍 Catches formatting issues early in the review process
• 🚫 Respects developer control - never modifies code automatically
• ✨ Provides helpful diffs and instructions

Closes #[issue_number]

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• esm.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Create github action that checks code formatting</issue_title>
<issue_description>We need a github action that checks the files in src/ggml-hsa if the follow the coding style. If the format is not correct, it should suggest a change but never make the change itself.

For Python files, it is enforced by black.

For C++, clang format is to be used with the file in https://github.com/ypapadop-amd/ggml/blob/hsa-backend/src/ggml-hsa/.clang-format</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #134

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.