Skip to content

feedback CastingAndIfElseService.java #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdesmond wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feedback CastingAndIfElseService.java #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Review/src/main/java/com/javafundamentals/services/CastingAndIfElseService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,17 @@ public class CastingAndIfElseService {
//demonstration of Implicit casting from int to double
int classScore = 85;
double dClassScore = classScore;

char classGrade;
char classGrade;

// RYAN: i see implicit casting above, but I do not see any other casting in this file
// so I added the constructor below just to demonstrate it:
public CastingAndIfElseService(int classScore, int dClassScore, int classGrade){
this.classScore = classScore;
this.dClassScore = (int) dClassScore;
this.classGrade = (int) classGrade;
short test1 = (short) classScore;
byte test2 = (byte) dClassScore;
}

//public constructor with parameters
public CastingAndIfElseService(int classScore, double dClassScore, char classGrade){
Expand Down