-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
feat(ButtonGroup): support button-group component #13774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wjw-gavin
wants to merge
3
commits into
youzan:main
Choose a base branch
from
wjw-gavin:feat/button-group
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { | ||
| defineComponent, | ||
| type PropType, | ||
| type InjectionKey, | ||
| type ExtractPropTypes, | ||
| } from 'vue'; | ||
| import { createNamespace, makeStringProp } from '../utils'; | ||
| import { useChildren } from '@vant/use'; | ||
| import type { ButtonSize, ButtonType } from './types'; | ||
|
|
||
| const [name, bem] = createNamespace('button-group'); | ||
|
|
||
| export const buttonGroupProps = { | ||
| type: makeStringProp<ButtonType>('primary'), | ||
| size: String as PropType<ButtonSize>, | ||
| round: Boolean, | ||
| }; | ||
|
|
||
| export type ButtonGroupProps = ExtractPropTypes<typeof buttonGroupProps>; | ||
|
|
||
| export type ButtonGroupProvide = { | ||
| props: ButtonGroupProps; | ||
| }; | ||
|
|
||
| export const BUTTON_GROUP_KEY: InjectionKey<ButtonGroupProvide> = Symbol(name); | ||
|
|
||
| export default defineComponent({ | ||
| name, | ||
|
|
||
| props: buttonGroupProps, | ||
|
|
||
| setup(props, { slots }) { | ||
| const { linkChildren } = useChildren(BUTTON_GROUP_KEY); | ||
|
|
||
| linkChildren({ props }); | ||
|
|
||
| return () => <div class={bem()}>{slots.default?.()}</div>; | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inheritance logic for the
roundprop has a potential bug. Sinceroundis aBooleanprop,props.roundwill always betrueorfalse. If a user explicitly sets:round="false"on aButtonwithin aButtonGroupthat hasround, the button will still inheritroundfrom the group becausefalse || group?.props.roundwould evaluate togroup?.props.round(which istrue). This prevents explicitfalseoverrides.To correctly handle explicit
falsevalues overriding parent props, you need to check if the prop was explicitly passed. A common pattern for this is to checkvnode.propsor adjust the prop definition to allowundefinedas a default, then check forundefined.For example, you could modify the
buttonPropsdefinition forroundto allowundefinedas a default, or usegetCurrentInstance()to checkinstance.vnode.props.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vue 的 Boolean prop 在未传时值是 false 不是 undefined 把，这样无法继承 group 属性了。
另外看 checker 中貌似是同样的问题，使用 getCurrentInstance 检查是否显式传入？