Skip to content

feat(FloatingPanel): add draggable prop#13773

Open
wjw-gavin wants to merge 2 commits intoyouzan:mainfrom
wjw-gavin:feat/floating-panel-draggable
Open

feat(FloatingPanel): add draggable prop#13773
wjw-gavin wants to merge 2 commits intoyouzan:mainfrom
wjw-gavin:feat/floating-panel-draggable

Conversation

@wjw-gavin
Copy link
Collaborator

close: #13770

Before submitting a pull request, please read the contributing guide.

在提交 pull request 之前,请阅读 贡献指南

@gemini-code-assist
Copy link

Summary of Changes

Hello @wjw-gavin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the FloatingPanel component by introducing a draggable prop, which provides developers with the ability to enable or disable the panel's dragging functionality. This feature allows for greater flexibility in UI design, enabling scenarios where a floating panel needs to remain static, thereby improving user experience and the component's adaptability to various application requirements.

Highlights

  • New draggable Prop: Introduced a new draggable prop to the FloatingPanel component, allowing explicit control over whether the panel can be dragged by the user. By default, it is true.
  • Conditional Dragging Logic: Implemented logic within the onTouchstart, onTouchmove, and onTouchend event handlers to prevent panel dragging when the draggable prop is set to false.
  • Header Bar Visibility: The default header drag bar is now conditionally rendered; it will be hidden when draggable is false, unless a custom header slot is provided.
  • Documentation Updates: Updated both English (README.md) and Chinese (README.zh-CN.md) documentation to include details, usage examples, and API table entries for the new draggable prop.
  • New Demo and Tests: Added a new demo case to showcase the FloatingPanel with dragging disabled and included comprehensive unit tests to verify the functionality of the draggable prop.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a draggable prop to the FloatingPanel component, allowing users to disable the dragging functionality. The implementation looks solid, including updates to the component logic, documentation, and tests. I've made one suggestion to simplify the logic in the onTouchend handler for better readability and maintainability.

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.01%. Comparing base (ec5b45b) to head (beb26d9).
⚠️ Report is 201 commits behind head on main.

Files with missing lines Patch % Lines
packages/vant/src/floating-panel/FloatingPanel.tsx 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13773      +/-   ##
==========================================
+ Coverage   89.60%   90.01%   +0.41%     
==========================================
  Files         257      257              
  Lines        7013     7064      +51     
  Branches     1736     1754      +18     
==========================================
+ Hits         6284     6359      +75     
+ Misses        384      369      -15     
+ Partials      345      336       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow FloatingPanel to be draggable or not

3 participants