-
Notifications
You must be signed in to change notification settings - Fork 187
Cherry pick PR #9040: Add script to be able to debug evergreen-x64 with vscode #9058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed: 483449996 (cherry picked from commit 43bea48)
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request cherry-picks a Python script for GDB to assist in debugging Cobalt Evergreen builds with VSCode, automatically loading symbols for dynamically loaded libraries. A medium-severity command injection vulnerability has been identified in the new GDB script, stemming from the construction of a GDB command with unvalidated input from the debugged process. The current sanitization is insufficient, requiring more robust input validation. Furthermore, the code review suggests improving the script's initialization to handle cases where the target breakpoint symbol might not be found, enhancing its robustness.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a cherry-pick of an upstream change, as indicated in the title and description. Per the repository's style guide (lines 11-17), detailed code style reviews are skipped for such changes since they have been reviewed in the original source. This review, therefore, focused on the correct application of the patch. The new Python script (starboard/tools/vscode_debug_evergreen.py) has been added correctly, and a high-level assessment indicates it is a well-contained and useful debugging utility. No issues were found with the application of this change.
Refer to the original PR: #9040
Fixed: 483449996