Skip to content

Conversation

@cobalt-github-releaser-bot
Copy link
Collaborator

Refer to the original PR: #9040

Fixed: 483449996

@github-actions
Copy link

🤖 Gemini Suggested Commit Message


Evergreen: Add VSCode debug helper script

Introduce a GDB Python script to automate symbol loading for
Evergreen shared libraries. This script hooks into the Evergreen
loader to detect when an ELF file is loaded, then uses
'add-symbol-file' with the correct memory offset.

This enhancement simplifies the debugging experience for Evergreen
components in environments like VSCode, where manually loading
symbols for dynamically mapped libraries is cumbersome.

Bug: 483449996

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a Python script for GDB to assist in debugging Cobalt Evergreen builds with VSCode, automatically loading symbols for dynamically loaded libraries. A medium-severity command injection vulnerability has been identified in the new GDB script, stemming from the construction of a GDB command with unvalidated input from the debugged process. The current sanitization is insufficient, requiring more robust input validation. Furthermore, the code review suggests improving the script's initialization to handle cases where the target breakpoint symbol might not be found, enhancing its robustness.

@andrewsavage1
Copy link
Contributor

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a cherry-pick of an upstream change, as indicated in the title and description. Per the repository's style guide (lines 11-17), detailed code style reviews are skipped for such changes since they have been reviewed in the original source. This review, therefore, focused on the correct application of the patch. The new Python script (starboard/tools/vscode_debug_evergreen.py) has been added correctly, and a high-level assessment indicates it is a well-contained and useful debugging utility. No issues were found with the application of this change.

@andrewsavage1 andrewsavage1 enabled auto-merge (squash) February 11, 2026 20:51
@andrewsavage1 andrewsavage1 merged commit 1eeb887 into main Feb 11, 2026
532 of 534 checks passed
@andrewsavage1 andrewsavage1 deleted the cherry-pick-main-9040 branch February 11, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants