Skip to content

Conversation

@cobalt-github-releaser-bot
Copy link
Collaborator

Refer to the original PR: #9022

Ensure the app_key buffer is properly sized before and after
calling GetAppKey. Previously, std::string::reserve was used
which allocated capacity but did not change the string's logical
size. This leads to app_key being empty, causing the
prefs store file name to be incorrect.

Bug: 431862767

Ensure the app_key buffer is properly sized before and after
calling GetAppKey. Previously, std::string::reserve was used
which allocated capacity but did not change the string's logical
size. This leads to app_key being empty, causing the
prefs store file name to be incorrect.

Bug: 431862767
(cherry picked from commit 438dbf3)
@cobalt-github-releaser-bot
Copy link
Collaborator Author

MERGE CONFLICT CAT

Caution

There were merge conflicts while cherry picking! Check out cherry-pick-main-9022 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/21893577578 for details.

@github-actions
Copy link

🤖 Gemini Suggested Commit Message


evergreen: Fix app key retrieval in pref store

Previously, std::string::reserve was used to size the app_key buffer
before calling GetAppKey. This only allocated capacity and did not
change the string's logical size.

This issue caused app_key to be empty, leading to an incorrect
prefs store file name. This change uses std::string::resize to
ensure the buffer is properly sized before and after GetAppKey.

Bug: 431862767

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants