Cherry pick PR #9037: android: Integrate disable-splash-screen flag #9047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Caution There were merge conflicts while cherry picking! Check out cherry-pick-26.android-9037 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/21887680273 for details. |
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
Move splash screen enablement check to command line. This change configures the --disable-splash-screen flag based on app metadata. This allows the Cobalt engine to skip creating the splash screen WebContents object entirely when it is not needed, which optimizes resource usage by avoiding unnecessary object creation. Issue: 483157506 (cherry picked from commit 3a82057)
borongc
force-pushed
the
cherry-pick-26.android-9037
branch
from
4b41501 to
70f920c
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a change to move the splash screen enablement check to a command-line flag. The changes look correct and successfully apply the intended logic. I've added one suggestion to improve the efficiency and robustness of the newly added appendArgsFromMetaData method by avoiding unnecessary object allocations and preventing duplicate command-line flags.
cobalt/android/apk/app/src/main/java/dev/cobalt/coat/CobaltActivity.java
Show resolved
Hide resolved
johnxwork
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #9037
Move splash screen enablement check to command line.
This change configures the --disable-splash-screen flag based on app
metadata. This allows the Cobalt engine to skip creating the splash
screen WebContents object entirely when it is not needed, which
optimizes resource usage by avoiding unnecessary object creation.
Issue: 483157506