Skip to content

Conversation

@cvinish
Copy link

@cvinish cvinish commented Feb 10, 2026

Add new unplugged/Inception end-to-end smoke test targets to android-arm and android-arm64 configurations.
Bug: 481037901

@cvinish cvinish requested review from Libzu and isarkis February 10, 2026 23:45
@github-actions
Copy link

🤖 Gemini Suggested Commit Message


android: Add Inception smoke tests to Android CI

Introduce new end-to-end smoke test targets for the Unplugged/
Inception application. These tests are added to the android-arm
and android-arm64 CI configurations to provide enhanced coverage
and validate core user flows on these platforms.

Bug: 481037901

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new end-to-end smoke test targets for 'Inception' to the android-arm and android-arm64 configurations. The changes are straightforward, but introduce significant duplication in the test configuration files. I've added a comment with a suggestion to explore ways to reduce this repetition to improve long-term maintainability.

Comment on lines 34 to 69
{
"target": "web/living_room/unplugged/testing/end2end/misc:smoke_login_test_custom_coat_kirkwood",
"test_attempts": "6"
},
{
"target": "web/living_room/unplugged/testing/end2end/misc:smoke_home_test_custom_coat_kirkwood",
"test_attempts": "6"
},
{
"target": "web/living_room/unplugged/testing/end2end/misc:smoke_watch_test_custom_coat_kirkwood",
"test_attempts": "6"
},
{
"target": "web/living_room/unplugged/testing/end2end/misc:smoke_login_test_custom_coat_boreal_non_shared",
"test_attempts": "6"
},
{
"target": "web/living_room/unplugged/testing/end2end/misc:smoke_home_test_custom_coat_boreal_non_shared",
"test_attempts": "6"
},
{
"target": "web/living_room/unplugged/testing/end2end/misc:smoke_watch_test_custom_coat_boreal_non_shared",
"test_attempts": "6"
},
{
"target": "web/living_room/unplugged/testing/end2end/misc:smoke_login_test_custom_coat_sabrina",
"test_attempts": "6"
},
{
"target": "web/living_room/unplugged/testing/end2end/misc:smoke_home_test_custom_coat_sabrina",
"test_attempts": "6"
},
{
"target": "web/living_room/unplugged/testing/end2end/misc:smoke_watch_test_custom_coat_sabrina",
"test_attempts": "6"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change adds a significant number of similar test targets, which leads to a lot of duplication. For instance, the smoke_login_test, smoke_home_test, and smoke_watch_test are repeated for kirkwood, boreal_non_shared, and sabrina.

While this might be a limitation of the current test configuration system, it would be beneficial for long-term maintainability to explore ways to reduce this repetition. For example:

  • Could these tests be grouped into a single test suite target in the build system?
  • Could this configuration file be generated from a more compact, parameterized source?

Reducing this duplication would make it easier to manage these tests, for example, when adding a new smoke test or a new device 'coat'.

Bug: 481037901
@cvinish cvinish requested a review from a team as a code owner February 11, 2026 00:02
@cvinish cvinish requested a review from oxve February 11, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants