-
Notifications
You must be signed in to change notification settings - Fork 187
Adds Inception Smoke Tests #9046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bug: 481037901
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds new end-to-end smoke test targets for 'Inception' to the android-arm and android-arm64 configurations. The changes are straightforward, but introduce significant duplication in the test configuration files. I've added a comment with a suggestion to explore ways to reduce this repetition to improve long-term maintainability.
| { | ||
| "target": "web/living_room/unplugged/testing/end2end/misc:smoke_login_test_custom_coat_kirkwood", | ||
| "test_attempts": "6" | ||
| }, | ||
| { | ||
| "target": "web/living_room/unplugged/testing/end2end/misc:smoke_home_test_custom_coat_kirkwood", | ||
| "test_attempts": "6" | ||
| }, | ||
| { | ||
| "target": "web/living_room/unplugged/testing/end2end/misc:smoke_watch_test_custom_coat_kirkwood", | ||
| "test_attempts": "6" | ||
| }, | ||
| { | ||
| "target": "web/living_room/unplugged/testing/end2end/misc:smoke_login_test_custom_coat_boreal_non_shared", | ||
| "test_attempts": "6" | ||
| }, | ||
| { | ||
| "target": "web/living_room/unplugged/testing/end2end/misc:smoke_home_test_custom_coat_boreal_non_shared", | ||
| "test_attempts": "6" | ||
| }, | ||
| { | ||
| "target": "web/living_room/unplugged/testing/end2end/misc:smoke_watch_test_custom_coat_boreal_non_shared", | ||
| "test_attempts": "6" | ||
| }, | ||
| { | ||
| "target": "web/living_room/unplugged/testing/end2end/misc:smoke_login_test_custom_coat_sabrina", | ||
| "test_attempts": "6" | ||
| }, | ||
| { | ||
| "target": "web/living_room/unplugged/testing/end2end/misc:smoke_home_test_custom_coat_sabrina", | ||
| "test_attempts": "6" | ||
| }, | ||
| { | ||
| "target": "web/living_room/unplugged/testing/end2end/misc:smoke_watch_test_custom_coat_sabrina", | ||
| "test_attempts": "6" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change adds a significant number of similar test targets, which leads to a lot of duplication. For instance, the smoke_login_test, smoke_home_test, and smoke_watch_test are repeated for kirkwood, boreal_non_shared, and sabrina.
While this might be a limitation of the current test configuration system, it would be beneficial for long-term maintainability to explore ways to reduce this repetition. For example:
- Could these tests be grouped into a single test suite target in the build system?
- Could this configuration file be generated from a more compact, parameterized source?
Reducing this duplication would make it easier to manage these tests, for example, when adding a new smoke test or a new device 'coat'.
Bug: 481037901
Add new unplugged/Inception end-to-end smoke test targets to android-arm and android-arm64 configurations.
Bug: 481037901