Cherry pick PR #8342 #8821 #8882: Play splash video from Main app's cache #9044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vcc schema and move hard coded webm to the embedded file (youtube#7997) See original youtube#8570: Register the H5VCC URL schema to the fetch API at render side. With the change, native splash implementation could call H5VCC to get the cached contents via fetch API. In the Cherry pick, I have to refactor a new target for "//cobalt/shell:url_constants", as in M114 cobalt_shell_lib is still under "testonly = true", which blocks us to use the constants in production targets. Issue: 454630524
…deo from Main app's cache (youtube#8854) See original PR: youtube#8342 youtube#8821 youtube#8882 Add cache reader to h5vcc loader to extract the splash video from local storage With it, youtube main app([www.youtube.com](http://www.youtube.com/)) could cache the splash video into local storage. At the following start, if the cache hits, h5vcc loader will return the local stored video to media source to display. h5vcc loader exposes two URL parameters for the callers: fallback: designate the webm file if cache is empty. For now only allow splash_480.webm for the low spec devices. cache: specify the cache name, default is "default". Check the h5vcc_scheme_url_loader_factory_browsertest.cc for the expected behaviors. Issue: 454630524
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables playing the splash video from the main application's cache, implementing a new BlobReader class and enhancing H5vccSchemeURLLoader to interact with the Cache Storage API. However, a medium-severity security vulnerability was identified: the cache query parameter is used from the URL without validation, potentially allowing access to other caches within the same origin. It is recommended to use a hardcoded cache name instead. Additionally, a minor issue was found in the new tests that could lead to flakiness, for which a suggestion has been provided.
borongc
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See original PR: #8342 #8821 #8882
Add cache reader to h5vcc loader to extract the splash video from local storage
With it, youtube main app(www.youtube.com) could cache the splash video into local storage. At the following start, if the cache hits, h5vcc loader will return the local stored video to media source to display.
h5vcc loader exposes two URL parameters for the callers:
fallback: designate the webm file if cache is empty. For now only allow splash_480.webm for the low spec devices.
cache: specify the cache name, default is "default".
Check the h5vcc_scheme_url_loader_factory_browsertest.cc for the expected behaviors.
Issue: 454630524