Skip to content

Conversation

@linxinan-chops
Copy link
Contributor

See original #8570:

Register the H5VCC URL schema to the fetch API at render side.

With the change, native splash implementation could call H5VCC to get the cached contents via fetch API.

In the Cherry pick, I have to refactor a new target for "//cobalt/shell:url_constants", as in M114 cobalt_shell_lib is still under "testonly = true", which blocks us to use the constants in production targets.

Issue: 454630524

…vcc schema and move hard coded webm to the embedded file (youtube#7997)

See original youtube#8570:

Register the H5VCC URL schema to the fetch API at render side.

With the change, native splash implementation could call H5VCC to get
the cached contents via fetch API.

In the Cherry pick, I have to refactor a new target for
"//cobalt/shell:url_constants", as in M114 cobalt_shell_lib is still
under "testonly = true", which blocks us to use the constants in
production targets.

Issue: 454630524
@linxinan-chops linxinan-chops requested a review from a team as a code owner February 10, 2026 22:22
@github-actions
Copy link

🤖 Gemini Suggested Commit Message


cobalt: Register H5VCC scheme for Fetch API

Register the H5VCC URL scheme to enable the Fetch API within
the renderer. This allows native splash screen implementations to
fetch cached content via the H5VCC scheme.

The change required refactoring the url_constants into a new build
target, as cobalt_shell_lib is testonly in M114, preventing its use
in production targets.

Bug: 454630524

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a cherry-pick to allow the renderer to fetch splash videos using the h5vcc schema. The changes correctly implement this by registering the h5vcc URL scheme with the Fetch API in the renderer process. The necessary refactoring of the BUILD.gn files to create a new url_constants target is also done correctly, allowing the renderer to access constants that were previously in a testonly target. The changes look good and are a correct application of the original patch to this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants