-
Notifications
You must be signed in to change notification settings - Fork 187
tvos: Fix VP9 header include path #9029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
The include path for vp9_hw_av_video_sample_buffer_builder.h was incorrectly using 'internal-starboard' prefix instead of 'starboard'. This causes build failures when INTERNAL_BUILD is defined since the preprocessor cannot locate the header file at the specified path. Bug: 452554667
cd62ab3 to
d72c9e8
Compare
|
cc: @jkim-julie @Gyuyoung |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request corrects an incorrect include path for a VP9 header on tvOS, which was causing build failures. The change updates the import path in av_video_sample_buffer_builder.mm and adds the necessary VP9 source files to the build system in BUILD.gn under the is_internal_build flag. The changes are correct, targeted, and effectively resolve the described build issue. I have no further comments.
rakuco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The include path for the VP9 hardware AV video sample buffer
builder header was incorrectly using the 'internal-starboard'
prefix. This change corrects the path to 'starboard' and ensures
the header is properly included in the build system when the
internal build flag is enabled. This resolves build failures
when the preprocessor cannot locate the header file.
Bug: 452554667