Skip to content

Conversation

@abhijeetk
Copy link
Collaborator

@abhijeetk abhijeetk commented Feb 10, 2026

The include path for the VP9 hardware AV video sample buffer
builder header was incorrectly using the 'internal-starboard'
prefix. This change corrects the path to 'starboard' and ensures
the header is properly included in the build system when the
internal build flag is enabled. This resolves build failures
when the preprocessor cannot locate the header file.

Bug: 452554667

@abhijeetk abhijeetk self-assigned this Feb 10, 2026
@github-actions
Copy link

🤖 Gemini Suggested Commit Message


tvos: Fix VP9 header include path

The include path for the VP9 hardware AV video sample buffer
builder header was incorrectly using the 'internal-starboard'
prefix. This change corrects the path to 'starboard' and ensures
the header is properly included in the build system when the
internal build flag is enabled. This resolves build failures
when the preprocessor cannot locate the header file.

Bug: 452554667

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

The include path for vp9_hw_av_video_sample_buffer_builder.h was
incorrectly using 'internal-starboard' prefix instead of 'starboard'.
This causes build failures when INTERNAL_BUILD is defined since the
preprocessor cannot locate the header file at the specified path.

Bug: 452554667
@abhijeetk abhijeetk force-pushed the add-vp9-hw-supporting-files branch from cd62ab3 to d72c9e8 Compare February 10, 2026 12:56
@abhijeetk abhijeetk requested a review from rakuco February 11, 2026 03:16
@abhijeetk
Copy link
Collaborator Author

cc: @jkim-julie @Gyuyoung

@abhijeetk abhijeetk changed the title tvOS: Fix VP9 hardware decoder header include path tvos: Fix VP9 header include path Feb 11, 2026
@abhijeetk abhijeetk marked this pull request as ready for review February 11, 2026 10:41
@abhijeetk abhijeetk requested a review from a team as a code owner February 11, 2026 10:41
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects an incorrect include path for a VP9 header on tvOS, which was causing build failures. The change updates the import path in av_video_sample_buffer_builder.mm and adds the necessary VP9 source files to the build system in BUILD.gn under the is_internal_build flag. The changes are correct, targeted, and effectively resolve the described build issue. I have no further comments.

Copy link
Collaborator

@rakuco rakuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I understand where this is coming from, but without @fayev-g and @oxve figuring out bug 460479616 this will remain broken anyway, won't it? Doesn't it make more sense to update the references in the non-public repositor{y,ies} in the meantime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants