starboard: Refactor PlayerWorker to use JobThread

[kjyoun]

This change replaces the manual Thread and JobQueue management in
PlayerWorker with JobThread. This simplifies the destruction sequence
and task scheduling within the player worker, improving code clarity
and robustness.

Bug: 468356861

[github-actions]

🤖 Gemini Suggested Commit Message

---

starboard: Refactor PlayerWorker to use JobThread

This change replaces the manual Thread and JobQueue management in
PlayerWorker with JobThread. This simplifies the destruction sequence
and task scheduling within the player worker, improving code clarity
and robustness.

Bug: 468356861

---

💡 Pro Tips for a Better Commit Message:

1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
2. Re-run the Generator: Post a comment with: /generate-commit-message

[kjyoun]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors PlayerWorker to use JobThread, which significantly simplifies thread management and the class's destruction sequence. The changes are well-executed, removing manual thread and job queue handling in favor of the JobThread abstraction. This also allowed for making many member variables const, improving the class's immutability and making it easier to reason about. The replacement of SB_DCHECK with SB_CHECK for thread-safety assertions is a good improvement for correctness. I have a few suggestions to further improve maintainability by using lambdas instead of std::bind, in line with modern C++ best practices and the Chromium style guide.

[gemini-code-assist]

Code Review

This pull request is a great improvement, refactoring PlayerWorker to use JobThread for thread and task management. This significantly simplifies the implementation, especially in the constructor and destructor, by removing manual thread synchronization logic. The increased use of const for member variables enhances robustness and code clarity. The switch from std::bind to lambdas for scheduling tasks is a welcome modernization. I have one suggestion to replace the remaining std::bind calls with lambdas for consistency.

[rakuco]

lgtm with a few suggestions. Thanks for picking this up!