refactor(ftplugin): move from vimscript to lua#40
Open
antinomie8 wants to merge 5 commits intoyousefakbar:mainfrom
Open
refactor(ftplugin): move from vimscript to lua#40antinomie8 wants to merge 5 commits intoyousefakbar:mainfrom
antinomie8 wants to merge 5 commits intoyousefakbar:mainfrom
Conversation
With the following improvements: - deleting mails in notmuch-threads removes them from the buffer immediately - fix undefined tag in mail.vim
antinomie8
force-pushed
the
refactor/lua-ftplugins
branch
from
b7a2578 to
dad33ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It annoyed me that when I deleted a mail with
ddinnotmuch-threads, the mails remained in the buffer and I had to refresh it to make them disappear. I think it would be a more intuitive behavior if the corresponding lines also got removed, that's why I began to port thenotmuch-threads.vimftplugin to lua to usevim.api.nvim_buf_set_linesfor removing the lines corresponding to deleted emails, and I ended up rewriting all the vimscript inftplugin/. Besides what I mentioned above there shouldn't be any other behavioral change, besides what I think is an error in ftplugin/mail.vim where it looks liketagis referenced but not defined.