Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14
실행 캡처
특이사항
14일 19시 기준, rds 에 pk 자료형 INT -> BIGINT 필요 & badge (자매대학, ACUCA..) 필드 필요
available_majors 에서 다시 파싱하여, 수강가능학과, 수강가능과목(url) 로 분리
remark 에서 학생 수 :{} 추출하여 응답 필드 분리
availableMajors와 remark 모두 정제된 데이터가 아니라, 임시로 dto에서 파싱하도록 구현했습니다. 기능적으로는 돌아가지만, 후에 확장성을 고려하면 리팩터링 필수일 듯 합니다. (정제된 데이터만 DB에 저장할지 여부 등등..)