Issue/57 update top image schema #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathmandu777
requested changes
Dec 17, 2022
Comment on lines
+35
to
+39
| cls, | ||
| request: Request, | ||
| id: str, | ||
| text_messages_limit: int, | ||
| image_messages_limit: int, |
Member
There was a problem hiding this comment.
formatterの修正が環境によってずれることあるかな？
Comment on lines
+88
to
+95
| image = Image.open(io.BytesIO(image_binary)).convert("RGB") | ||
| image_io = io.BytesIO() | ||
| image_name = "top_image.jpeg" | ||
| image.save(image_io, format="JPEG") | ||
| image_file = InMemoryUploadedFile(image_io, field_name=None, name=image_name, | ||
| content_type="image/jpeg", size=image_io.getbuffer().nbytes, | ||
| charset=None) | ||
| project.top_image = image_file |
Member
There was a problem hiding this comment.
未検証
かなり回りくどい実装っぽいけどとりあえずいいや
# TODO: 簡略化
みたいなこめんとあるといいかも
fastapi/app/models/project.py
Outdated
| return random.choice(spotify_uri_candidates) | ||
|
|
||
|
|
||
| def upload_to_top_image(instance: "Project", filename: str) -> str: |
Member
There was a problem hiding this comment.
instance -> project
でいいと思うけどどうでしょうか？
Member
Author
There was a problem hiding this comment.
んーーどういうことかいまいちわかってないかも..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
お気持ち: top imageの値をimage_messageと同じ感じにしたい
動作確認済み
Issue number
Close #57
How to check the revision
Points for Review
Remarks
急いで書いたから, 細かいところまで配慮できてないかも...
余裕があったらみてほしい