[ID-Mapped Mount] Impl Channel & Message#3409
Open
YamasouA wants to merge 4 commits intoyouki-dev:mainfrom
Open
[ID-Mapped Mount] Impl Channel & Message#3409YamasouA wants to merge 4 commits intoyouki-dev:mainfrom
YamasouA wants to merge 4 commits intoyouki-dev:mainfrom
Conversation
YamasouA
commented
Feb 15, 2026
| UnexpectedMessage { | ||
| expected: Message, | ||
| received: Message, | ||
| expected: Box<Message>, |
Contributor
Author
There was a problem hiding this comment.
Boxed to keep ChannelError small and avoid clippy::result_large_err.
5719013 to
07afe2a
Compare
Contributor
Author
|
/retest |
20bdaa6 to
07afe2a
Compare
Member
|
Could you please share the final design plan using a sequence diagram or similar documentation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
“I implemented ID-mapped mount support based on runc’s approach. In this PR, I extended the channel between Main and Init to allow passing mount FDs, and added unit tests.”
Type of Change
Testing
Related Issues
Fixes #2307
Additional Context
The following PR has too many changes, so it will be split and submitted for review.
#3384