Skip to content

Comments

[ID-Mapped Mount] Impl Channel & Message#3409

Open
YamasouA wants to merge 4 commits intoyouki-dev:mainfrom
YamasouA:ft/id-mapped-mount-channel-message
Open

[ID-Mapped Mount] Impl Channel & Message#3409
YamasouA wants to merge 4 commits intoyouki-dev:mainfrom
YamasouA:ft/id-mapped-mount-channel-message

Conversation

@YamasouA
Copy link
Contributor

@YamasouA YamasouA commented Feb 15, 2026

Description

“I implemented ID-mapped mount support based on runc’s approach. In this PR, I extended the channel between Main and Init to allow passing mount FDs, and added unit tests.”

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite
  • Tested manually (please provide steps)

Related Issues

Fixes #2307

Additional Context

The following PR has too many changes, so it will be split and submitted for review.
#3384

Signed-off-by: YamasouA <akiakiskyhand@gmail.com>
Signed-off-by: Akiyama <akiakiskyhand@gmail.com>
Signed-off-by: Akiyama <akiakiskyhand@gmail.com>
@YamasouA YamasouA marked this pull request as draft February 15, 2026 15:11
UnexpectedMessage {
expected: Message,
received: Message,
expected: Box<Message>,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boxed to keep ChannelError small and avoid clippy::result_large_err.

Signed-off-by: Akiyama <akiakiskyhand@gmail.com>
@YamasouA YamasouA force-pushed the ft/id-mapped-mount-channel-message branch from 5719013 to 07afe2a Compare February 15, 2026 16:09
@YamasouA
Copy link
Contributor Author

/retest

@YamasouA YamasouA marked this pull request as ready for review February 19, 2026 15:10
@YamasouA YamasouA force-pushed the ft/id-mapped-mount-channel-message branch from 20bdaa6 to 07afe2a Compare February 19, 2026 15:12
@utam0k
Copy link
Member

utam0k commented Feb 20, 2026

Could you please share the final design plan using a sequence diagram or similar documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support idmapped mount

2 participants