Open
Conversation
Member
Author
|
Switching to use a different implementation (rather than a Fragment in a Dialog, use a DialogFramgent) as the previous way does not work correctly (first opening of the bottom sheet is fine, but any further openings cause crashes. I imagine the previous implementation required something doing a bit more with lifecycle stuff but since it's complex enough for the Android devs to write DialogFragment for us I'm not going to bother with it. Can't actually get this to work, however and I can't seem to figure out what I'm doing wrong ;-;
Temporary. No point lingering on this if we can't figure out what's wrong. Just gonna try to keep the code clean for now, I expect there will be some lifecycle bugs, but we'll fix those as we come across them. Also: camelCase for views
Some view updates (questionable) and API logic in the presenter too. The saves are currently being done in onPause (incorrectly).
This is a bit.. big? Woops.
There should be a better way of determinng where we want the reveal start/end points than just the touch location. The text and stuff does not change colour with the background yet. Also, there's a bug where the first couple changes don't get animated 💭
And some minor cleanup / not-so-cleanup
For backported transitions. See https://medium.com/@andkulikov/animate-all-the-things-transitions-in-android-914af5477d50
And also some half-finished stuff work on the status dropdown colouring (commented). And also merge fixes.
doesn't actually fix what i want it to (background doesn't show up but rest of colors change)
Less opaque (more transparent)
And some todo/print statement cleanup.
To be used with ViewManagers. Also moved into their own project.
Also... - Add visisbility modifiers on AestheticsDelegate - Fix StatusResolvers to not be so shit
dulleh
force-pushed
the
library-update
branch
from
f914ba7 to
ec35541
Compare
And convert getColor() to expression body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.