Skip to content

Extra parser class to allow instance reuse, memory buffers reuse.#8

Closed
zubrabubra wants to merge 1 commit intoyonik:masterfrom
zubrabubra:reusable-parser
Closed

Extra parser class to allow instance reuse, memory buffers reuse.#8
zubrabubra wants to merge 1 commit intoyonik:masterfrom
zubrabubra:reusable-parser

Conversation

@zubrabubra
Copy link

No description provided.

@rmuller
Copy link

rmuller commented Jul 24, 2017

Did you benchmark this code? And yes, what is the performance gain compared with the trunk code?
In my experience the gain is very small, if any and highly platform dependent.
Otherwise, it is a nice addition.

@zubrabubra
Copy link
Author

In my case it was used in DeviceHive server to reduce memory usage, garbage collection time, and finally have more CPU left for the application itself. But i'm not working with DH for a quite a long time now, thus probably would be good to close PR, as it looks like author deprecated library.

@rmuller
Copy link

rmuller commented Jul 24, 2017

Okay, fair enough.

BTW, I do not think this lib is deprecated. It is updated quite recently.

@zubrabubra
Copy link
Author

@rmuller i saw, however PR was not accepted, nor rejected.

@zubrabubra
Copy link
Author

Closing as there is better PR with JMH #20

@zubrabubra zubrabubra closed this Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants