Skip to content

Conversation

@dabico
Copy link
Contributor

@dabico dabico commented Jan 3, 2026

Added endpointslices to the list of resources to the ClusterRole/Role installed by the chart.

What this PR does / why we need it?

Without this permission, Service instances might be omitted from the final report when running kor as a CRON job on a cluster.

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs
  • This PR updates the Helm chart

GitHub Issue

Closes #544

@yonahd
Copy link
Owner

yonahd commented Jan 4, 2026

@dabico Please bump the chart version in chart.yaml and then run
docker run --rm --volume "$(pwd):/helm-docs" -u $(id -u) jnorwood/helm-docs:latest

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.81%. Comparing base (48648be) to head (8c68d6d).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   45.81%   45.81%           
=======================================
  Files          69       69           
  Lines        3933     3933           
=======================================
  Hits         1802     1802           
  Misses       1832     1832           
  Partials      299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dabico
Copy link
Contributor Author

dabico commented Jan 4, 2026

@yonahd hi, done!

@yonahd yonahd merged commit 9b3471e into yonahd:main Jan 4, 2026
2 checks passed
@dabico dabico deleted the dabico/permissions branch January 4, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kor does not have access to endpointslices when running as a CRON job on a cluster

3 participants