generated from ynput/ayon-addon-template
-
Notifications
You must be signed in to change notification settings - Fork 8
Add activity stream panel to the openrv menu #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
moonyuet
wants to merge
23
commits into
develop
Choose a base branch
from
feature/implement_activity_streams_panel
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgument is correct for ReviewController menu
…so that it won't mess up the openrv widget
- Extract common panel opening logic into `open_desktop_review_panel` method - Create `add_desktop_review_menu_items` to dynamically generate menu items for all available review panels instead of hardcoding individual methods - Remove commented-out `activity_stream` and `detail_panel` methods - Use `functools.partial` to bind panel names to the generic panel opener - Replace `load_stylesheet` with `style_widget_and_siblings` from ayon_ui_qt - Simplify menu_item method by delegating review panel setup to helper method Signed-off-by: philippe-ynput <philippe@ynput.io>
…is some loaded old assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sponsored
This is directly sponsored by a client or community member
type: feature
Adding something new and exciting to the product
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR is to add activity stream panel to the openrv menu
Links to https://github.com/ynput/ayon-review-desktop/issues/12
Additional review information
Tested with https://github.com/ynput/ayon-review-desktop/pull/17
Testing notes:
activity streamin the ayon menu