-
Notifications
You must be signed in to change notification settings - Fork 67
Extract Review: Substance Painter reviewables do not integrate #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Extract Review: Substance Painter reviewables do not integrate #1588
Conversation
moonyuet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me
…w-doesnt-refresh-on-new-assignments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I have tested this does not work...when using tags delete and need_thumbnail which results into not having any sort of reviewable but just thumbnail...

so I guess this combo of tags is not working for having reviewable and must be adjusted.

On positive side of things, yes there is no additional repre integrated tho...
There must be probably different tag used other than need_thumbnail
|
@jakubjezek001 @iLLiCiTiT do you happen to know what the right combination would be here? This is the preferred outcome:
|
…w-doesnt-refresh-on-new-assignments
|
I guess this deservers an issue. Right now there is a lot of compatibilities and checks that are out of date, or out of use-cases. We could go through all of that and change the thumbnail creation behavior. |
Changelog Description
With #1526 we got reviewables for substance painter textures, but they also got integrated as representations, like
png_png.Additional info
With these changes it should only make the reviewable upload.
See ayon chat conversation; https://discord.com/channels/517362899170230292/563751989075378201/1447931139263168553
Community and @LiborBatek says that these are working settings:
https://discord.com/channels/517362899170230292/1447896320101580851/1447972537060298902
Testing notes: