Skip to content

Conversation

@BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Dec 9, 2025

Changelog Description

With #1526 we got reviewables for substance painter textures, but they also got integrated as representations, like png_png.

Additional info

With these changes it should only make the reviewable upload.

See ayon chat conversation; https://discord.com/channels/517362899170230292/563751989075378201/1447931139263168553

Community and @LiborBatek says that these are working settings:

image

https://discord.com/channels/517362899170230292/1447896320101580851/1447972537060298902

Testing notes:

  1. Reviewables should be uploaded, but no extra representation should be integrated.

@BigRoy BigRoy requested a review from LiborBatek December 9, 2025 15:25
@BigRoy BigRoy self-assigned this Dec 9, 2025
@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Dec 9, 2025
@ynbot ynbot added type: bug Something isn't working size/XS labels Dec 9, 2025
@BigRoy BigRoy requested review from antirotor and moonyuet December 9, 2025 15:26
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I have tested this does not work...when using tags delete and need_thumbnail which results into not having any sort of reviewable but just thumbnail...
image

so I guess this combo of tags is not working for having reviewable and must be adjusted.
image

On positive side of things, yes there is no additional repre integrated tho...

There must be probably different tag used other than need_thumbnail

@BigRoy
Copy link
Collaborator Author

BigRoy commented Dec 12, 2025

@jakubjezek001 @iLLiCiTiT do you happen to know what the right combination would be here?

This is the preferred outcome:

  1. Do not integrate the image as representation.
  2. Generate a thumbnail.
  3. Add as reviewable.

@iLLiCiTiT
Copy link
Member

I guess this deservers an issue. Right now there is a lot of compatibilities and checks that are out of date, or out of use-cases. We could go through all of that and change the thumbnail creation behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS type: bug Something isn't working type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants