-
Notifications
You must be signed in to change notification settings - Fork 67
🏛️Product base types: Support in Creator logic #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iLLiCiTiT
merged 42 commits into
develop
from
enhancement/1297-product-base-types-creation-and-creator-plugins
Dec 4, 2025
Merged
🏛️Product base types: Support in Creator logic #1306
iLLiCiTiT
merged 42 commits into
develop
from
enhancement/1297-product-base-types-creation-and-creator-plugins
Dec 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
BigRoy
reviewed
Jun 4, 2025
…ion-and-creator-plugins
…ion-and-creator-plugins
…ion-and-creator-plugins
…roduct-base-types-creation-and-creator-plugins
…roduct-base-types-creation-and-creator-plugins
…ion-and-creator-plugins
…pes-creation-and-creator-plugins' into enhancement/1297-product-base-types-creation-and-creator-plugins
iLLiCiTiT
reviewed
Nov 26, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iLLiCiTiT
approved these changes
Nov 27, 2025
…ion-and-creator-plugins
iLLiCiTiT
reviewed
Dec 4, 2025
This was referenced Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
size/S
sponsored
This is directly sponsored by a client or community member
type: enhancement
Improvement of existing functionality or minor addition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Add support for product base types to creation logic in ayon-core.
Additional info
This is the first part of gradient transition of
product typeto optional alias forproduct base type. To keep the backwards compatibility,product base typeis introduced as an optional argument to most of the existing functions. If it is not passed, warning is emitted - this will in most cases comes from the Creator plugins not implementing product base types.So far - on the data model -
product typeis mandatory andproduct base typeis nullable field. This will change in the future whenproduct_base_typeis consistently used across all the addons out there.Reflecting
product_base_typein product name won't work if creator plugin overridesget_product_name()function. If it does, it needs to be refactored.Also, the way how Creators create
CreatedInstancediffers so this must be considered too. The logic goes like this:If
product_base_typeis passed to the constructor, it will be used. If not and the creator (it needs to be passed there too) itself definesproduct_base_type, it will use that one.There are some questions lingering:
How to handle
product_base_typein Anatomy and Product name templates until it is made mandatory? If you have{product[baseType]}token in your templates:product_typeproduct_base_typeproduct_base_typeNote
Closes #1297
Warning
This will break Maya integration if ynput/ayon-maya#282 is not resolved and maybe other hosts.
Testing notes:
For more information see description of #1297