Skip to content

Conversation

@antirotor
Copy link
Member

@antirotor antirotor commented Jun 3, 2025

Changelog Description

Add support for product base types to creation logic in ayon-core.

Additional info

This is the first part of gradient transition of product type to optional alias for product base type. To keep the backwards compatibility, product base type is introduced as an optional argument to most of the existing functions. If it is not passed, warning is emitted - this will in most cases comes from the Creator plugins not implementing product base types.

So far - on the data model - product type is mandatory and product base type is nullable field. This will change in the future when product_base_type is consistently used across all the addons out there.

Reflecting product_base_type in product name won't work if creator plugin overrides get_product_name() function. If it does, it needs to be refactored.

Also, the way how Creators create CreatedInstance differs so this must be considered too. The logic goes like this:

If product_base_type is passed to the constructor, it will be used. If not and the creator (it needs to be passed there too) itself defines product_base_type, it will use that one.

There are some questions lingering:

How to handle product_base_type in Anatomy and Product name templates until it is made mandatory? If you have {product[baseType]} token in your templates:

product_type product_base_type
✔️ use product_type
✔️ use product_base_type
is invalid state
✔️ ✔️ use product_base_type

Note

Closes #1297

Warning

This will break Maya integration if ynput/ayon-maya#282 is not resolved and maybe other hosts.

Testing notes:

For more information see description of #1297

@antirotor antirotor self-assigned this Jun 3, 2025
@antirotor antirotor added the type: enhancement Improvement of existing functionality or minor addition label Jun 3, 2025
@antirotor antirotor linked an issue Jun 3, 2025 that may be closed by this pull request
@antirotor antirotor added the sponsored This is directly sponsored by a client or community member label Jun 3, 2025
@ynbot ynbot added the size/S label Jun 3, 2025
@ynbot ynbot moved this to Review In Progress in PR reviewing Jun 4, 2025
@antirotor antirotor marked this pull request as ready for review June 10, 2025 09:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-project-automation github-project-automation bot moved this from Review In Progress to Merge Requested in PR reviewing Nov 27, 2025
@ynbot ynbot moved this from Merge Requested to Review In Progress in PR reviewing Dec 4, 2025
@iLLiCiTiT iLLiCiTiT merged commit 523ac20 into develop Dec 4, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in PR reviewing Dec 4, 2025
@iLLiCiTiT iLLiCiTiT deleted the enhancement/1297-product-base-types-creation-and-creator-plugins branch December 4, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump minor size/S sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

🏛️Product base types: Creation and creator plugins

5 participants