Don't set facing on initial position update#74
Merged
Desdaemon merged 1 commit intoynoproject:masterfrom Aug 5, 2025
Merged
Conversation
Prevents clients from having their facing set to east in case they don't send an `f` packet after connecting. The cause was the `x > c.x` condition always being hit (any valid X coordinate > -1). Prior to 651597c the extra condition wasn't strictly necessary because north-facing (default, no `f` sent) clients would've hit `c.y < y` (-1 < any valid Y coordinate) and have their facing set to north again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents clients from having their facing set to east in case they don't send an
fpacket after connecting. The cause was thex > c.xcondition always being hit (any valid X coordinate > -1). Prior to 651597c the extra condition wasn't strictly necessary because north-facing (default, nofsent) clients would've hitc.y < y(-1 < any valid Y coordinate) and have their facing set to north again.Reproduction steps:
Facing of player 1 as seen by player 2 after doing all of the above: