Add support for 'schema.registry.url' property in ConsumerConfig and ProducerConfig schemas #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you so much for creating and maintaining this library – it's really a pleasure to use.
This PR adds an optional consumer and producer config key,
schema.registry.url, so Franzy's Schema validations can play nice with the Confluent Platform.Per Confluent's documentation, the
schema.registry.urlproperty should be in the general Properties passed to the Kafka Consumer on instantiation.Currently, things work out of the box. It'd just be nice to have Schema validations work, too, instead of throwing an error.
Would also love to hear thoughts on potentially more idiomatic ways to accomplish this.