Skip to content

Improve URL handling to prevent constructor errors #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ylevch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve URL handling to prevent constructor errors #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions js/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,17 @@ chrome.tabs.onUpdated.addListener(function () {
function (tabs) {
var currenturl = tabs[0].url;
var googlebooksmatch = RegExp("(?:https?:\/\/)?(?:www.)?books.google.[a-zA-Z]*").test(currenturl);
var url = new URL(currenturl);
var args = new URLSearchParams(url.search);
var id = args.get('id');
if (googlebooksmatch && id != null) {
var newurl = "https://www.google.com/books/edition/_/" + id;
chrome.tabs.update(null, {
url: newurl
});
};

if (googlebooksmatch) {
var url = new URL(currenturl);
var args = new URLSearchParams(url.search);
var id = args.get('id');
if (id != null) {
var newurl = "https://www.google.com/books/edition/_/" + id;
chrome.tabs.update(null, {
url: newurl
});
};
}
});
});