This repository was archived by the owner on Dec 2, 2019. It is now read-only.
Feat delayed [WIP]#53
Open
evanxg852000 wants to merge 3 commits intoyldio:masterfrom
evanxg852000:feat-delayed
Open
Feat delayed [WIP]#53evanxg852000 wants to merge 3 commits intoyldio:masterfrom evanxg852000:feat-delayed
evanxg852000 wants to merge 3 commits intoyldio:masterfrom
evanxg852000:feat-delayed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR as I still need to write unitest.
But I have been trying to discuss about whether this feature is useful as it involves a slight api change.
two functions will be exported from now on. maybe a better idea to keep the api as is while providing this feature.
I need to get early feedback.
Synopsis:
[08 Oct, 2017 ]
Hi,
I am Evance,
I have been using this redux middleware in our organisation project.
lately we needed a way to support dynamic db. that is the database is not available when creating the redux store but will be available later on.
I have modified a fork to support this feature. This feature now exports tow functions from the module rather one.
I want you to have a look and suggest how the feature could be added while avoiding two functions export (breaking change)
Also let me know in the same line if this feature has any chance of making his way on the main stream.
I have not written test cases for the new features thought since I want to make sure there is an agreement on the api interface first.
https://github.com/evanxg852000/pouch-redux-middleware/blob/feat-delayed/src/index.js#L7
I will be happy to hear feedback from you
Thanks
So far I have had not reply to this email. So i thought creating a PR might be a better way to start discussion