Skip to content
This repository was archived by the owner on Dec 2, 2019. It is now read-only.

issue#46#49

Open
tarr11 wants to merge 1 commit intoyldio:masterfrom
tarr11:master
Open

issue#46#49
tarr11 wants to merge 1 commit intoyldio:masterfrom
tarr11:master

Conversation

@tarr11
Copy link
Copy Markdown
Contributor

@tarr11 tarr11 commented Jun 9, 2017

This addresses issue #46 by storing a cache of changes, so that each db only subscribes to changes a single time.

@Magellol
Copy link
Copy Markdown

Magellol commented Jun 26, 2017

Nice. I think the solution does the job.
Although, I'm not sure about how we should merge this in so I guess pinging @pgte seems appropriate.

I feel the tests should reflect the changes as well if possible.

As a suggestion, I feel we could push this a bit further because even if we're caching change subscriptions, we're still calling listen on each path, which downloads all documents from each db (so potentially from the same DB as well: https://github.com/yldio/pouch-redux-middleware/blob/master/src/index.js#L49). I think ideally we'd download docs only once for each DB, then apply the filters as needed.

@Magellol
Copy link
Copy Markdown

Magellol commented Jul 6, 2017

Hey guys, any update on getting this merged in or updated? Thanks! cc @tarr11 @pgte

@gabrielmancini
Copy link
Copy Markdown

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants