Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new code style convention for chained method calls by configuring ESLint to enforce no additional indentation for member expressions. The changes include updating the ESLint configuration, reformatting existing code to comply with the new style, and updating several development dependencies.
Changes:
- Added ESLint indent rule with
MemberExpression: 0to prevent indentation in chained method calls - Added
multiline-ternaryrule set to 'never' to enforce single-line ternary expressions - Reformatted chained method calls in webpack plugins, Redux Toolkit reducers, and promise chains to align with new style
- Updated development dependencies including ty, eslint plugins, oxlint, and stylelint
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/config/eslint.js | Added indent rule configuration with MemberExpression: 0 and multiline-ternary: never to enforce style |
| packages/webpack/plugins.ts | Reformatted resolver factory hook chain to remove indentation from chained .for() and .tap() calls |
| examples/tanstack/start/ui/AnimationSidebar.tsx | Reformatted promise chain to remove indentation from .then() and .catch() calls |
| examples/tanstack/start/src/external-stores/ReduxToolkit.tsx | Reformatted Redux Toolkit builder pattern to remove indentation from chained .addCase() calls |
| pyproject.toml | Updated ty package from 0.0.16 to 0.0.17 |
| packages/config/package.json | Updated eslint-plugin-better-tailwindcss (4.2.0→4.3.0), eslint-plugin-react-you-might-not-need-an-effect (0.8.5→0.9.1), oxlint (1.47.0→1.48.0), and stylelint (17.2.0→17.3.0) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.