Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Ruff lint configuration to allow single-line compound statements (via ignoring E701) and applies that style to a few notebook and benchmarking scripts.
Changes:
- Ignore Ruff/Pycodestyle rule
E701(single-line compound statements likeif x: y) in the shared Ruff config. - Convert a handful of multi-line
if/forblocks into single-line statements in notebooks and an HTTP benchmark script.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/config/ruff.toml | Ignores E701, enabling single-line compound statements across the repo. |
| notebooks/reinforcement_learning/frozen_lake.py | Rewrites simple if blocks into single-line if ...: .... |
| notebooks/random/simple_benchmarks.py | Rewrites a for loop and an early-return if into single-line forms. |
| notebooks/machine_learning/nmf.py | Rewrites two guard/assignment if blocks into single-line statements. |
| examples/http/_bench/benchmark.py | Rewrites a loop break condition into a single-line if ...: break. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.