Skip to content

style: drop ruff format in favor of pycodestyle rules#132

Merged
yjoer merged 1 commit intomasterfrom
yj
Feb 13, 2026
Merged

style: drop ruff format in favor of pycodestyle rules#132
yjoer merged 1 commit intomasterfrom
yj

Conversation

@yjoer
Copy link
Owner

@yjoer yjoer commented Feb 13, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 13, 2026 10:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s Python linting/formatting approach by moving away from ruff format enforcement and toward a curated Ruff rule selection (including pycodestyle E/W), with accompanying code edits to satisfy the new lint rules and some dependency bumps.

Changes:

  • Replace ruff’s select = ["ALL"] with an explicit rule set (including E/W) and adjust ignores to support 2-space indentation.
  • Disable ruff format checks in pre-commit/lint-staged and in the reusable CI workflow, while keeping ruff check.
  • Apply small code edits across notebooks/examples/datasets to satisfy lint suggestions (Pathlib helpers, encoding, small simplifications).

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
solutions/sports/yolo_v8.py Adds # noqa: SIM113 on step increment.
solutions/sports/numbers/resnet.py Adds # noqa: SIM113 on step increment.
pyproject.toml Updates dev dependency versions (incl. ruff) and adds ty.
packages/config/ruff.toml Switches from ALL to an explicit Ruff select list; adds/adjusts ignores.
packages/config/package.json Bumps JS tooling versions (eslint plugins, oxlint).
packages/config/lint-staged.js Comments out ruff format --check and mypy for staged .py files.
notebooks/vision/faster_rcnn.py Uses Path.write_text/read_text/write_bytes/read_bytes with explicit UTF-8 encoding.
notebooks/vision/fashion_mnist.py Adds # noqa: SIM113 on step increment.
notebooks/text/ngram_language_models.py Replaces slice-copy with .copy().
notebooks/reinforcement_learning/lunar_lander.py Simplifies deque initialization.
notebooks/reinforcement_learning/frozen_lake.py Minor simplifications (set membership; tuple key style).
notebooks/random/color_models.py Switches to in-place division for normalization.
examples/http/_bench/utils.py Adds explicit UTF-8 encoding when appending results JSON lines.
examples/grafana/smartctl/apply.py Adds explicit UTF-8 encoding for temp JSON file.
camp/utils/jupyter_utils.py Adds lint suppression for _render_traceback_.
camp/datasets/soccernet.py Adds explicit UTF-8 encoding; suppresses “no-self-use” lint.
camp/datasets/mnist.py Refactors parsing/tensor conversion into module-level helpers.
camp/datasets/ikcest.py Renames unused ctor arg from subset to _subset.
.github/workflows/verify-py.yml Disables the format-py job via if: false.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yjoer yjoer force-pushed the yj branch 3 times, most recently from 3e79a98 to fb63013 Compare February 13, 2026 11:11
@yjoer yjoer merged commit 4ab43d9 into master Feb 13, 2026
9 checks passed
@yjoer yjoer deleted the yj branch February 13, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant