Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s formatting/linting approach to handle long Tailwind class strings via ESLint (better-tailwindcss), while removing/avoiding Prettier’s Tailwind-related plugins and applying a number of small formatting cleanups across stories/examples.
Changes:
- Add
eslint-plugin-better-tailwindcssrules to enforce class wrapping/order and tighten Tailwind class validation. - Replace the previous Prettier/Prettier-compat ESLint setup with
@stylistic/eslint-plugin-based style rules. - Reduce Prettier “check” coverage in CI/lint-staged to non-JS assets (with JS/TS handled by ESLint).
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| stories/src/Sidebar.stories.tsx | Small formatting changes and Tailwind class normalization (border-l-1 → border-l). |
| stories/src/GradientBorderCard.stories.tsx | Wrap long class list across lines; normalize border/padding class; adds an ESLint rule disable. |
| packages/webpack/plugins.ts | Formatting-only change in arrow callback style. |
| packages/config/prettier.js | Comments out Tailwind/classnames-related Prettier plugins/options. |
| packages/config/package.json | Adds better-tailwindcss + stylistic deps; removes Prettier Tailwind-related deps; bumps tooling versions. |
| packages/config/lint-staged.js | Moves Prettier checks to non-JS assets; relies on ESLint for JS/TS. |
| packages/config/eslint.js | Adds better-tailwindcss config and new stylistic config; refactors several rule blocks. |
| examples/webpack/typescript-fastify/rspack.config.ts | Formatting tweaks; removes eslint-disable; quoting normalization. |
| examples/webpack/typescript-fastify/mods/handlers.ts | Formatting tweak in Promise callback. |
| examples/tanstack/start/src/external-stores/Zustand.tsx | Formatting tweaks for arrow functions/Promise callbacks. |
| examples/tanstack/start/src/external-stores/ReduxToolkit.tsx | Formatting tweaks for selectors/Promise callbacks. |
| examples/tanstack/start/src/external-stores/Redux.tsx | Formatting tweaks for selectors/Promise callbacks. |
| examples/tanstack/start/src/TransitionZustand.tsx | Formatting tweaks for Zustand store selectors/creators. |
| examples/tanstack/start/src/TransitionUseState.tsx | Formatting tweak for setState callbacks. |
| examples/tanstack/start/src/TransitionUseSearch.tsx | Formatting tweak for search updater + state update callback. |
| examples/tanstack/start/src/TransitionUseContextSelector.tsx | Formatting tweaks for selectors and state updates. |
| examples/tanstack/start/src/TransitionRedux.tsx | Formatting tweaks for selectors. |
| examples/tanstack/start/src/StaleClosures.tsx | Formatting tweaks for setState callbacks. |
| examples/tanstack/start/postcss.config.js | Removes eslint-disable. |
| examples/tanstack/start/babel.config.js | Re-wraps plugin config object for style consistency. |
| examples/tanstack/start-solid/src/TransitionSignal.tsx | Formatting tweaks for setState callbacks. |
| examples/tanstack/start-solid/src/StaleClosures.tsx | Formatting tweaks for setState callbacks. |
| examples/tanstack/start-solid/postcss.config.js | Removes eslint-disable. |
| examples/tanstack/start-solid/babel.config.js | Re-wraps plugin config object for style consistency. |
| examples/react/server-rendering/vite/server.ts | Formatting tweak for Promise callback. |
| examples/react/server-rendering/vite/server-stream.ts | Formatting tweak for Promise callback. |
| examples/react/server-rendering/scripts/bench.ts | Object key quoting normalization. |
| examples/node/basics/fs.ts | Formatting tweaks for arrow callbacks. |
| examples/hatchet/typescript-connectors/connectors/dropbox.ts | Header key quoting normalization; formatting tweaks for callbacks. |
| .github/workflows/verify-js.yml | Narrows Prettier check glob to non-JS assets (and includes mdx). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.