-
-
Notifications
You must be signed in to change notification settings - Fork 27
Add a middleware for automatic ID creation for messages before push #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a4b73cc
Add a middleware for automatic ID creation for messages before push
viktorprogger 9e539fe
Add tests
viktorprogger 51964d4
Update src/Middleware/Push/Implementation/IdMiddleware.php
viktorprogger 862a802
More precious tests
viktorprogger ea8387f
Fix message id chacking
viktorprogger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Yiisoft\Queue\Middleware\Push\Implementation; | ||
|
|
||
| use Yiisoft\Queue\Message\IdEnvelope; | ||
| use Yiisoft\Queue\Middleware\Push\MiddlewarePushInterface; | ||
| use Yiisoft\Queue\Middleware\Push\PushRequest; | ||
| use Yiisoft\Queue\Middleware\Push\MessageHandlerPushInterface; | ||
|
|
||
| /** | ||
| * A middleware for message ID setting. | ||
| */ | ||
| final class IdMiddleware implements MiddlewarePushInterface | ||
| { | ||
| public function processPush(PushRequest $request, MessageHandlerPushInterface $handler): PushRequest | ||
| { | ||
| $meta = $request->getMessage()->getMetadata(); | ||
| if (empty($meta[IdEnvelope::MESSAGE_ID_KEY])) { | ||
| $request = $request->withMessage(new IdEnvelope($request->getMessage(), uniqid('yii3-message-', true))); | ||
| } | ||
|
|
||
| return $handler->handlePush($request); | ||
| } | ||
| } | ||
55 changes: 55 additions & 0 deletions
55
tests/Unit/Middleware/Push/Implementation/IdMiddlewareTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Yiisoft\Queue\Tests\Unit\Middleware\Push\Implementation; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use Yiisoft\Queue\Message\IdEnvelope; | ||
| use Yiisoft\Queue\Message\Message; | ||
| use Yiisoft\Queue\Middleware\Push\Implementation\IdMiddleware; | ||
| use Yiisoft\Queue\Middleware\Push\MessageHandlerPushInterface; | ||
| use Yiisoft\Queue\Middleware\Push\PushRequest; | ||
|
|
||
| final class IdMiddlewareTest extends TestCase | ||
| { | ||
| public function testWithId(): void | ||
| { | ||
| $message = new Message('test', null, [IdEnvelope::MESSAGE_ID_KEY => 'test-id']); | ||
| $originalRequest = new PushRequest($message, null); | ||
| $handler = $this->createMock(MessageHandlerPushInterface::class); | ||
|
|
||
| $handler->expects($this->once()) | ||
| ->method('handlePush') | ||
| ->willReturnArgument(0); | ||
|
|
||
| $middleware = new IdMiddleware(); | ||
| $finalRequest = $middleware->processPush($originalRequest, $handler); | ||
|
|
||
| $this->assertSame($originalRequest, $finalRequest); | ||
| $this->assertNotInstanceOf(IdEnvelope::class, $finalRequest->getMessage()); | ||
| $this->assertEquals('test-id', $finalRequest->getMessage()->getMetadata()[IdEnvelope::MESSAGE_ID_KEY]); | ||
| $this->assertSame($originalRequest->getMessage()->getData(), $finalRequest->getMessage()->getData()); | ||
| $this->assertSame($originalRequest->getMessage()->getHandlerName(), $finalRequest->getMessage()->getHandlerName()); | ||
| } | ||
|
|
||
| public function testWithoutId(): void | ||
| { | ||
| $message = new Message('test', null); | ||
| $originalRequest = new PushRequest($message, null); | ||
| $handler = $this->createMock(MessageHandlerPushInterface::class); | ||
|
|
||
| $handler->expects($this->once()) | ||
| ->method('handlePush') | ||
| ->willReturnArgument(0); | ||
|
|
||
| $middleware = new IdMiddleware(); | ||
| $finalRequest = $middleware->processPush($originalRequest, $handler); | ||
|
|
||
| $this->assertInstanceOf(IdEnvelope::class, $finalRequest->getMessage()); | ||
| $this->assertNotSame($originalRequest, $finalRequest); | ||
| $this->assertNotEmpty($finalRequest->getMessage()->getMetadata()[IdEnvelope::MESSAGE_ID_KEY] ?? null); | ||
| $this->assertSame($originalRequest->getMessage()->getData(), $finalRequest->getMessage()->getData()); | ||
| $this->assertSame($originalRequest->getMessage()->getHandlerName(), $finalRequest->getMessage()->getHandlerName()); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.