Allow to call QueueProvideer::withChannelName()#116
Open
viktorprogger wants to merge 4 commits intomasterfrom
Open
Allow to call QueueProvideer::withChannelName()#116viktorprogger wants to merge 4 commits intomasterfrom
viktorprogger wants to merge 4 commits intomasterfrom
Conversation
Contributor
viktorprogger
commented
May 4, 2025
viktorprogger
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | #115 |
samdark
approved these changes
May 6, 2025
…with-channel-name-creation # Conflicts: # src/Exception/ExchangeDeclaredException.php
vjik
requested changes
May 18, 2025
| $this->channel->exchange_declare(...$this->exchangeSettings->getPositionalSettings()); | ||
| $this->channel->queue_bind($this->queueSettings->getName(), $this->exchangeSettings->getName()); | ||
| } | ||
| $this->channel->exchange_declare(...$this->exchangeSettings->getPositionalSettings()); |
Member
There was a problem hiding this comment.
$this->exchangeSettings can be null, so an error may occur in this line. Refactor class to exclude case when private ?AMQPChannel $channel = null; may be null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.