Skip to content

Conversation

@pamparam83
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #141

Added a check for dark mode.
If the system’s theme cannot be detected, we default to the light theme.
Due to a known issue in Linux OS (see https://issues.chromium.org/issues/40642550),
Linux users will also get the light theme by default.

@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.47%. Comparing base (5eb18b6) to head (6a23707).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #142   +/-   ##
=========================================
  Coverage     77.47%   77.47%           
  Complexity      184      184           
=========================================
  Files            14       14           
  Lines           586      586           
=========================================
  Hits            454      454           
  Misses          132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to remove section "@media (prefers-color-scheme: dark) { ..." from CSS

@pamparam83
Copy link
Contributor Author

It needs to remove section "@media (prefers-color-scheme: dark) { ..." from CSS

this will cause flickering.
checked in Brave

@xepozz
Copy link
Member

xepozz commented Mar 18, 2025

It needs to remove section "@media (prefers-color-scheme: dark) { ..." from CSS

this will cause flickering. checked in Brave

Btw, you may access cookies in backend

@pamparam83
Copy link
Contributor Author

It needs to remove section "@media (prefers-color-scheme: dark) { ..." from CSS

this will cause flickering. checked in Brave

Btw, you may access cookies in backend

flickering occurs
1 no cookies
2 dark theme enabled

@xepozz
Copy link
Member

xepozz commented Mar 18, 2025

  1. it's ok
  2. could be possible fixed by setting theme on the server

anyway, "flickering" occurs without your changes, isn't it?

@pamparam83
Copy link
Contributor Author

@vjik
I made some edits, please take a look

@samdark samdark requested a review from vjik March 25, 2025 20:12
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line to changelog

@vjik vjik merged commit a30abc5 into yiisoft:master Mar 27, 2025
22 checks passed
@vjik
Copy link
Member

vjik commented Mar 27, 2025

Thank you @pamparam83 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants