Skip to content

Improve performance of AbstractSqlParser class methods#1159

Merged
Tigrov merged 6 commits intomasterfrom
improve-sql-parser
Feb 9, 2026
Merged

Improve performance of AbstractSqlParser class methods#1159
Tigrov merged 6 commits intomasterfrom
improve-sql-parser

Conversation

@Tigrov
Copy link
Member

@Tigrov Tigrov commented Feb 7, 2026

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues

Related PR

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.60%. Comparing base (1f38570) to head (271e974).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1159      +/-   ##
============================================
- Coverage     98.63%   98.60%   -0.03%     
+ Complexity     1654     1645       -9     
============================================
  Files           120      120              
  Lines          4313     4292      -21     
============================================
- Hits           4254     4232      -22     
- Misses           59       60       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samdark
Copy link
Member

samdark commented Feb 7, 2026

@Tigrov any benchmarks?

@samdark samdark requested a review from Copilot February 7, 2026 08:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Optimizes AbstractSqlParser hot-path parsing utilities by replacing per-character loops with span functions and regex-based skipping.

Changes:

  • Added LETTER_CHARS / WORD_CHARS constants and switched word/identifier parsing to strspn().
  • Replaced several scanning loops with strspn() / strcspn() and preg_match() approaches.
  • Added function imports for the new APIs used.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tigrov
Copy link
Member Author

Tigrov commented Feb 7, 2026

@Tigrov any benchmarks?

Yes, tested locally. Almost 2 times faster 🚀

image

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tigrov Tigrov added the status:code review The pull request needs review. label Feb 7, 2026
@Tigrov Tigrov requested a review from a team February 7, 2026 09:09
@Tigrov Tigrov merged commit b2b6eb0 into master Feb 9, 2026
3 checks passed
@Tigrov Tigrov deleted the improve-sql-parser branch February 9, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants