Improve performance of AbstractSqlParser class methods#1159
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1159 +/- ##
============================================
- Coverage 98.63% 98.60% -0.03%
+ Complexity 1654 1645 -9
============================================
Files 120 120
Lines 4313 4292 -21
============================================
- Hits 4254 4232 -22
- Misses 59 60 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Tigrov any benchmarks? |
There was a problem hiding this comment.
Pull request overview
Optimizes AbstractSqlParser hot-path parsing utilities by replacing per-character loops with span functions and regex-based skipping.
Changes:
- Added
LETTER_CHARS/WORD_CHARSconstants and switched word/identifier parsing tostrspn(). - Replaced several scanning loops with
strspn()/strcspn()andpreg_match()approaches. - Added function imports for the new APIs used.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Yes, tested locally. Almost 2 times faster 🚀
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Related PR
SqlParser::getNextPlaceholder()method db-pgsql#482