destory时增加必要的unRegister #87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
添加销毁已注册的监听
destroy的时候增加调用IFloatWindow中的destory,销毁已注册的监听，另增加destroyAll()
Author
|
还有destory的我感觉也有必要resetStartCount吧？ |
hhhaiai
pushed a commit
to SDKers/FloatWindow
that referenced
this pull request
Jan 22, 2019
Author
|
SDKers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前destory只是仅仅做了dismiss的操作，不符合销毁的含义，而且异常情况也可能destory了还会显示（registerActivityLifecycleCallbacks），所以在destory的时候unRegister还是有必要的。多谢