Update v1 branch #23
Merged
Update v1 branch #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yen-tt
commented
Nov 16, 2022
yen-tt
commented
- Update WCAG github action to accept mapbox API key (Update WCAG github action to accept mapbox API key #22)
When testing wcag in search-react-ui repo, the mapbox API key is required to use Mapbox GL in storybook. Updated the workflow to optionally accept a mapbox API key as an env variable for the build step. J=none TEST=manual tested in this PR: yext/search-ui-react#331, where wcag error `An API access token is required to use Mapbox GL.` is no longer present after using the workflow from this branch.
oshi97
approved these changes
Nov 16, 2022
Contributor
oshi97
left a comment
oshi97
left a comment
There was a problem hiding this comment.
b1 -> v1 in the title right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.