Skip to content

Conversation

@k-gerner
Copy link
Contributor

@k-gerner k-gerner commented Jan 6, 2026

This is to pick up the limit param functionality for the /autocomplete endpoint

J=WAT-5265
TEST=auto
Updated tests

@k-gerner k-gerner requested a review from a team as a code owner January 6, 2026 22:53
@coveralls
Copy link

coveralls commented Jan 6, 2026

Pull Request Test Coverage Report for Build 20792148852

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 91.358%

Totals Coverage Status
Change from base Build 19110753473: 0.09%
Covered Lines: 381
Relevant Lines: 408

💛 - Coveralls

@k-gerner k-gerner added the WIP label Jan 6, 2026
Fondryext
Fondryext previously approved these changes Jan 7, 2026
Copy link
Contributor

@Fondryext Fondryext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 files for a one character change is rough hahaha

Copy link
Contributor

@anguyen-yext2 anguyen-yext2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind addressing the lint warnings about the commas?

@k-gerner
Copy link
Contributor Author

k-gerner commented Jan 7, 2026

would you mind addressing the lint warnings about the commas?

Done!

@k-gerner k-gerner merged commit ed42aeb into main Jan 7, 2026
11 checks passed
@k-gerner k-gerner deleted the autocomplete-limit-v2.8.0 branch January 7, 2026 18:33
@k-gerner k-gerner removed the WIP label Jan 7, 2026
@k-gerner k-gerner changed the title chore: bump search-core to v2.8.0 chore: bump search-core to v2.8.0 to support autocomplete limit Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants