-
Notifications
You must be signed in to change notification settings - Fork 4
Support trusted publishing with OIDC #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
J=WAT-5077 TEST=manual forked the repo to my personal git account. Verified that: - the `ci-verify-publish` script output the correct release tag - the `release` and `release:dry` scripts work as expected on a new patch, minor, major, alpha, beta, and custom version copied over the relevant changes from the forked repo. Verified that: - the `ci-verify-publish` script output the correct release tag - the `release:dry` script make the expected changes locally
Pull Request Test Coverage Report for Build 18297306928Details
💛 - Coveralls |
Fondryext
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this all makes sense to me, although I'm not too familiar with the publish process.
So silly question - what's the new release flow work like? Do we just make a new release/tag in Github, and these scripts get triggered and everything works from there without our input?
I plan to approve this shortly but wanted to give any other engineers a chance to check as well
I'll confirm with Sumo later to see if they're doing the same thing, but here is how I was testing it: |
Just confirmed with Ben that Sumo's flow is similar |
Fondryext
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying!
|
Let's update the Search SDK documentation to take into account the new release flow (after this / the other changes are shipped). |
* update Visitor to show visitorId max length * Support trusted publishing with OIDC (#308) J=WAT-5077 TEST=manual forked the repo to my personal git account. Verified that: - the `ci-verify-publish` script output the correct release tag - the `release` and `release:dry` scripts work as expected on a new patch, minor, major, alpha, beta, and custom version copied over the relevant changes from the forked repo. Verified that: - the `ci-verify-publish` script output the correct release tag - the `release:dry` script make the expected changes locally --------- Co-authored-by: Kyle Gerner <kgerner@yext.com> Co-authored-by: Kyle Gerner <49618240+k-gerner@users.noreply.github.com> Co-authored-by: anguyen-yext2 <143001514+anguyen-yext2@users.noreply.github.com>
* update Visitor to show visitorId max length * Support trusted publishing with OIDC (#308) J=WAT-5077 TEST=manual forked the repo to my personal git account. Verified that: - the `ci-verify-publish` script output the correct release tag - the `release` and `release:dry` scripts work as expected on a new patch, minor, major, alpha, beta, and custom version copied over the relevant changes from the forked repo. Verified that: - the `ci-verify-publish` script output the correct release tag - the `release:dry` script make the expected changes locally * Support facetAllowlist query parameter for vertical searches (#310) Allows the "facetAllowlist" parameter to be set on vertical searches. This parameter specifies the subset of field IDs that are configured as facet fields that facet options should be returned for in the search response. If unspecified, all fields configured as facetable can be returned if they have data for the given query. J=WAT-4928 TEST=manual Added a query to the test-site vertical requests that returns facets. Confirmed that the facetAllowlist parameter is settable and works as expected. * Undo version bump to 2.6.4 (#312) We have changed the release flow to be compatible with OIDC. * release: @yext/search-core@2.6.4 * Revert "release: @yext/search-core@2.6.4" This reverts commit d32e762. * release: @yext/search-core@2.6.4 * hotfix: fix release tag in trusted publishing workflow (#316) * release: v2.7.0-beta.0 * release: v2.7.0-beta.1 * chore: use reusable publish workflow (#320) * release: v2.7.0-beta.2 * release: v2.7.0 * rerun `npm i && npm run build` up to date, audited 921 packages in 1s 169 packages are looking for funding run `npm fund` for details 4 low severity vulnerabilities To address all issues (including breaking changes), run: npm audit fix --force Run `npm audit` for details. --------- Co-authored-by: Kyle Gerner <kgerner@yext.com> Co-authored-by: Kyle Gerner <49618240+k-gerner@users.noreply.github.com> Co-authored-by: anguyen-yext2 <143001514+anguyen-yext2@users.noreply.github.com> Co-authored-by: mkouzel-yext <mkouzel@yext.com> Co-authored-by: anguyen-yext2 <anguyen@yext.com>
J=WAT-5077
TEST=manual
forked the repo to my personal git account. Verified that:
ci-verify-publishscript output the correct release tagreleaseandrelease:dryscripts work as expected on a new patch, minor, major, alpha, beta, and custom versioncopied over the relevant changes from the forked repo. Verified that:
ci-verify-publishscript output the correct release tagrelease:dryscript make the expected changes locally