Add optional name property to near field value filters #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16150530701Details
💛 - Coveralls |
During filter search, the value of a near filter in a result corresponds to the name of the location for that filter. We already support setting the "name" property on a near filter in the backend, so we can start setting the "name" property on the frontend, too. Tested by changing the filterSearchRequest in test-site's autocompleteRequests.ts to query the Locations vertical and builtin.location field on location entities using the input "vir". Saw that the name field was set on the resulting near field value filters to whatever the location of the filter was (e.g. "Virginia, USA").
The vertical key is "faqs", not "faq". There is also no links vertical.
mkouzel-yext
force-pushed
the
dev/near-filter-name-prop
branch
from
ec7b29a to
c764d16
Compare
anguyen-yext2
approved these changes
Jul 8, 2025
mkouzel-yext
added a commit
that referenced
this pull request
Jul 8, 2025
* ksearch: add openAt Matcher This PR adds support for the openAt Matcher, which is used for filtering to those entities which are currently open. J=WAT-4905 TEST=auto Added small unit test * Automated update to repo's documentation from github action * Add optional name property to near field value filters (#302) During filter search, the value of a near filter in a result corresponds to the name of the location for that filter. We already support setting the "name" property on a near filter in the backend, so we can start setting the "name" property on the frontend, too. Tested by changing the filterSearchRequest in test-site's autocompleteRequests.ts to query the Locations vertical and builtin.location field on location entities using the input "vir". Saw that the name field was set on the resulting near field value filters to whatever the location of the filter was (e.g. "Virginia, USA"). Also added unit test. Also fixes universal search request in test-site. --------- Co-authored-by: Jacob Fondriest <jfondriest@yext.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Fondryext <160865254+Fondryext@users.noreply.github.com> Co-authored-by: mkouzel-yext <mkouzel@yext.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During filter search, the value of a near filter in a result corresponds to the name of the location for that filter. We already support setting the "name" property on a near filter in the backend, so we can start setting the "name" property on the frontend, too.
Tested by changing the filterSearchRequest in test-site's autocompleteRequests.ts to query the Locations vertical and builtin.location field on location entities using the input "vir". Saw that the name field was set on the resulting near field value filters to whatever the location of the filter was (e.g. "Virginia, USA").
Also fixes vertical keys in the test-site's universal request.