feat: swap to tsup for builds

[mkilpatrick]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 28a8b8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

This PR expands React compatibility and adjusts build/test tooling for pages-components. Tests now include React 18.2.0 and 19.2.3 in CI and local test scripts. packages/pages-components package.json changes the build flow (primary build now runs tsup && pnpm build:css, adds build:vite) and loosens peerDependencies for react and react-dom to allow ^18.2.0 or ^19.2.3. Vite externals now include react/jsx-runtime and react/jsx-dev-runtime. Two CSS imports were removed, test-results/ was added to .gitignore, and the starter test-site dependencies were bumped to React 18.2.0.

Sequence Diagram(s)

(omitted)

Possibly related PRs

• feat: support React 19 #138: Also expands React test matrix and updates pages-components peerDependencies to include React 19 while adjusting Vite externals.
• fix: exclude react/jsx-runtime from build #124: Modifies packages/pages-components/vite.config.ts to externalize React JSX runtimes (react/jsx-runtime/react/jsx-dev-runtime).
• revert: prior changes and build with React 18 #127: Changes pages-components build pipeline and package.json build/peer dependency entries (Vite vs tsup adjustments and React peer range updates).

Suggested reviewers

• asanehisa
• benlife5
• colton-demetriou

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided, making it impossible to assess whether it relates to the changeset.	Add a description explaining the rationale for swapping to tsup, any performance benefits, testing approach, and compatibility considerations with React 18/19.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'feat: swap to tsup for builds' accurately reflects the main change: migrating the build system from Vite to tsup in package.json.

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 673e877 and 28a8b8a.

📒 Files selected for processing (1)

• packages/pages-components/tsup.config.ts

💤 Files with no reviewable changes (1)

• packages/pages-components/tsup.config.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: call_test_matrix / Node 20 • React 18.2.0
• GitHub Check: call_test_matrix / Node 22 • React 19.2.3
• GitHub Check: call_test_matrix / Node 24 • React 18.2.0
• GitHub Check: call_test_matrix / Node 20 • React 19.2.3
• GitHub Check: call_test_matrix / Node 24 • React 19.2.3
• GitHub Check: call_test_matrix / Node 22 • React 18.2.0
• GitHub Check: update_snapshots / test (20.x)
• GitHub Check: semgrep/ci

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f5bfaf and 673e877.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (7)

• .github/workflows/test-matrix.yml
• packages/pages-components/package.json
• packages/pages-components/src/components/index.css
• packages/pages-components/vite.config.ts
• test-sites/pages-components-starter/.gitignore
• test-sites/pages-components-starter/package.json
• test-sites/pages-components-starter/scripts/test-matrix-local.sh

💤 Files with no reviewable changes (1)

• packages/pages-components/src/components/index.css

🔇 Additional comments (5)

test-sites/pages-components-starter/.gitignore (1)

7-7: LGTM!

Adding test-results/ to gitignore is the standard practice for Playwright test artifacts.

packages/pages-components/vite.config.ts (1)

17-23: LGTM! Correct externals for React 17+ JSX transform.

Adding react/jsx-runtime and react/jsx-dev-runtime to externals is necessary for React 17+ automatic JSX transform compatibility. These modules should remain external to avoid bundling React's JSX runtime in the library output.

test-sites/pages-components-starter/package.json (1)

20-21: LGTM! React dependencies updated consistently.

The React and React DOM dependencies are updated from 17.x to 18.x, with corresponding type definitions updated. This aligns with the broader PR objective to support React 18 and 19.

Also applies to: 26-27

test-sites/pages-components-starter/scripts/test-matrix-local.sh (1)

13-13: LGTM! Local test matrix expanded to cover React 19.

The addition of React 19.2.3 to the test matrix aligns with the workflow changes and ensures local testing matches the CI environment.

.github/workflows/test-matrix.yml (1)

14-14: LGTM! Test matrix expanded to validate React 18 and 19 compatibility.

The addition of React 19.2.3 to the test matrix ensures the library is validated against both supported React major versions, creating comprehensive coverage across 6 Node/React combinations.