Skip to content

feat: support React 19 #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkilpatrick merged 2 commits into from
Dec 29, 2025
Merged

feat: support React 19 #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ab2113
feat: support React 19
mkilpatrick Dec 23, 2025
050e73d
Automated linting/prettier update
github-actions[bot] Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-matrix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
fail-fast: false # Continue other combos even if one fails
matrix:
node: [20, 22, 24]
react: ["18.2.0"] # TODO: Add "19.2.1" when ready
react: ["18.2.0", "19.2.3"]

steps:
- name: "Checkout"
Expand Down
4 changes: 2 additions & 2 deletions packages/pages-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@
"peerDependencies": {
"lexical": "~0.38.2",
"mapbox-gl": "^2.9.2",
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react": "^18.2.0 || ^19.2.3",
"react-dom": "^18.2.0 || ^19.2.3"
},
"devDependencies": {
"@playwright/test": "^1.55.1",
Expand Down
8 changes: 7 additions & 1 deletion packages/pages-components/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@ export default defineConfig(() => ({
formats: ["es"] as LibraryFormats[], // typescript is unhappy without this forced type definition
},
rollupOptions: {
external: ["react", "react-dom", "mapbox-gl"],
external: [
"react",
"react-dom",
"mapbox-gl",
"react/jsx-runtime",
"react/jsx-dev-runtime",
],
output: {
globals: {
react: "React",
Expand Down
357 changes: 183 additions & 174 deletions pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion test-sites/pages-components-starter/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ dist/
node_modules/
playwright-report/
sites-rendered-output/
deno.lock
deno.lock
test-results/
8 changes: 4 additions & 4 deletions test-sites/pages-components-starter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
},
"dependencies": {
"@yext/pages-components": "workspace:*",
"react": "^17.0.2",
"react-dom": "^17.0.2"
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
"devDependencies": {
"@playwright/test": "^1.57.0",
"@types/node": "^20.9.1",
"@types/react": "^17.0.2",
"@types/react-dom": "^17.0.2",
"@types/react": "^18.2.0",
"@types/react-dom": "^18.2.0",
"@vitejs/plugin-react": "^4.3.3",
"@yext/pages": "^1.2.7",
"typescript": "^5.3.3",
Expand Down
2 changes: 1 addition & 1 deletion test-sites/pages-components-starter/scripts/test-matrix-local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if ! command -v nvm >/dev/null 2>&1; then
fi

NODE_VERSIONS=("20" "22" "24")
REACT_VERSIONS=("18.2.0") # TODO: Add "19.2.1"
REACT_VERSIONS=("18.2.0" "19.2.3")

INITIAL_NODE_VERSION=$(node -v)
echo "🔍 Detected initial Node version: $INITIAL_NODE_VERSION"
Expand Down
Loading