Skip to content

Conversation

@mkilpatrick
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

⚠️ No Changeset found

Latest commit: ba47d0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2025

Walkthrough

This PR removes React 17 support by standardizing on React 18.2.0 across the codebase. The changes restrict the testing matrix in the GitHub Actions workflow and local test script to only React 18.2.0, and update the peerDependencies in packages/pages-components/package.json to require React 18.2.x exclusively. Node.js testing matrix remains unchanged at versions 18, 20, 22, and 24. No functional logic or public APIs are modified.

Possibly related PRs

Suggested reviewers

  • asanehisa
  • benlife5

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making this a completely empty description that conveys no information about the changeset. Add a brief description explaining why React 17 support is being dropped and any migration guidance for users still on React 17.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat!: drop support for React 17' directly and accurately describes the main objective of the changeset, which removes React 17 from testing matrices and peer dependencies.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch drop-17

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from drop-rtf to main December 23, 2025 15:44
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57eb25e and c1f5a97.

📒 Files selected for processing (3)
  • .github/workflows/test-matrix.yml
  • packages/pages-components/package.json
  • test-sites/pages-components-starter/scripts/test-matrix-local.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: call_unit_test / unit_tests (18.x)
  • GitHub Check: call_unit_test / unit_tests (22.x)
  • GitHub Check: call_test_matrix / Node 18 • React 18.2.0
  • GitHub Check: call_unit_test / unit_tests (20.x)
  • GitHub Check: call_test_matrix / Node 20 • React 18.2.0
  • GitHub Check: call_test_matrix / Node 24 • React 18.2.0
  • GitHub Check: call_test_matrix / Node 22 • React 18.2.0
  • GitHub Check: update_snapshots / test (20.x)
  • GitHub Check: update_snapshots / test (18.x)
  • GitHub Check: semgrep/ci
🔇 Additional comments (2)
test-sites/pages-components-starter/scripts/test-matrix-local.sh (1)

13-13: LGTM! React 17 successfully removed from test matrix.

The change correctly aligns the local test script with the PR objective to drop React 17 support. The array now only contains React 18.2.0, consistent with the updated peerDependencies and workflow configuration.

Note: The TODO comment about adding React 19.2.1 should be addressed in coordination with the peerDependencies discussion in package.json.

.github/workflows/test-matrix.yml (1)

14-14: LGTM! CI matrix updated to test only React 18.2.0.

The workflow matrix correctly removes React 17 testing and standardizes on React 18.2.0, aligning with the package.json peerDependencies update. The Node version matrix remains appropriately comprehensive at [18, 20, 22, 24].

Note: As mentioned in the package.json review, the TODO comment about React 19.2.1 should be addressed in coordination with peerDependencies constraints.

@mkilpatrick mkilpatrick merged commit 1e812b5 into main Dec 23, 2025
20 of 21 checks passed
@mkilpatrick mkilpatrick deleted the drop-17 branch December 23, 2025 16:46
@coderabbitai coderabbitai bot mentioned this pull request Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants