-
Notifications
You must be signed in to change notification settings - Fork 3
feat!: drop support for React 17 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThis PR removes React 17 support by standardizing on React 18.2.0 across the codebase. The changes restrict the testing matrix in the GitHub Actions workflow and local test script to only React 18.2.0, and update the peerDependencies in packages/pages-components/package.json to require React 18.2.x exclusively. Node.js testing matrix remains unchanged at versions 18, 20, 22, and 24. No functional logic or public APIs are modified. Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/test-matrix.ymlpackages/pages-components/package.jsontest-sites/pages-components-starter/scripts/test-matrix-local.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: call_unit_test / unit_tests (18.x)
- GitHub Check: call_unit_test / unit_tests (22.x)
- GitHub Check: call_test_matrix / Node 18 • React 18.2.0
- GitHub Check: call_unit_test / unit_tests (20.x)
- GitHub Check: call_test_matrix / Node 20 • React 18.2.0
- GitHub Check: call_test_matrix / Node 24 • React 18.2.0
- GitHub Check: call_test_matrix / Node 22 • React 18.2.0
- GitHub Check: update_snapshots / test (20.x)
- GitHub Check: update_snapshots / test (18.x)
- GitHub Check: semgrep/ci
🔇 Additional comments (2)
test-sites/pages-components-starter/scripts/test-matrix-local.sh (1)
13-13: LGTM! React 17 successfully removed from test matrix.The change correctly aligns the local test script with the PR objective to drop React 17 support. The array now only contains React 18.2.0, consistent with the updated peerDependencies and workflow configuration.
Note: The TODO comment about adding React 19.2.1 should be addressed in coordination with the peerDependencies discussion in package.json.
.github/workflows/test-matrix.yml (1)
14-14: LGTM! CI matrix updated to test only React 18.2.0.The workflow matrix correctly removes React 17 testing and standardizes on React 18.2.0, aligning with the package.json peerDependencies update. The Node version matrix remains appropriately comprehensive at [18, 20, 22, 24].
Note: As mentioned in the package.json review, the TODO comment about React 19.2.1 should be addressed in coordination with peerDependencies constraints.
No description provided.