Open
Conversation
yesoer
force-pushed
the
fix/neovim-quit-last-win-crash
branch
from
f2c7686 to
5654414
Compare
So the 'Engine' field is exported, which we can use to manipulate the behaviour i.e. prevent quitting of all windows.
Before using e.g. :q when only one window was left would crash the widget. Now q is substituted by Ex. This may not be the final fix.
yesoer
force-pushed
the
fix/neovim-quit-last-win-crash
branch
from
cb7716d to
130a009
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quitting all windows crashes the neovim widget. This is prevented through abbervations of all the comments that could lead to that : q, wq, qa, x etc.