Skip to content

yesod-static: use mime-types >= 0.1.2.1 Content-Type for JS #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parsonsmatt merged 3 commits into from
Jan 20, 2026
Merged

yesod-static: use mime-types >= 0.1.2.1 Content-Type for JS #1898

parsonsmatt merged 3 commits into from
Jan 20, 2026
+11 −2

Conversation

@sternenseemann
Copy link
Contributor

@sternenseemann sternenseemann commented Jan 16, 2026 •
edited
Loading

Resolves #1897 in the simplest way. Unfortunately it is not possible to check for the fourth version component using CPP.

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@sternenseemann sternenseemann mentioned this pull request Jan 16, 2026
Draft
@parsonsmatt
Copy link
Contributor

parsonsmatt commented Jan 16, 2026

Do you mind adding a patch version bump, changelog note? That helps us get it released

@snoyberg @psibi @meteficha I don't have upload rights on Hackage for yesod-static - y'all want to take this and/or add me as maintainer?

@psibi
Copy link
Member

psibi commented Jan 17, 2026

@parsonsmatt I have added you to hackage.

@sternenseemann
Copy link
Contributor Author

sternenseemann commented Jan 17, 2026

I can do that. I think it would be prudent to upload yesod-static 1.6.1.1 and 1.6.1.2 independently beforehand since this change is of course going to restrict install plans just for the sake of the test suite.

I was wondering if it would be better to just check for one of the two content types in the test suite.

@sternenseemann sternenseemann force-pushed the yesod-static-mime-types-0.1.2.1 branch from 706842e to 619b876 Compare January 18, 2026 11:34
@sternenseemann
Copy link
Contributor Author

sternenseemann commented Jan 18, 2026

Do you mind adding a patch version bump, changelog note? That helps us get it released

Done.

@sternenseemann
yesod-static: fix test suite with mime-types >= 0.1.2.1
f391ee1 
mime-types 0.1.2.1 changed the MIME type of JavaScript files to
text/javascript. In most situation, it is unproblematic to also
allow the old MIME type (application/javascript), so we don't
need to arbitrarily restrict the lower bound on mime-types (this
can still be done by users if necessary).

Resolves yesodweb#1897.
@sternenseemann sternenseemann force-pushed the yesod-static-mime-types-0.1.2.1 branch from 619b876 to f391ee1 Compare January 18, 2026 11:35
@parsonsmatt
Copy link
Contributor

parsonsmatt commented Jan 20, 2026

Thanks for the note on the release - I've combined the two prior versions into a released 1.6.1.1, which would make this 1.6.1.2.

parsonsmatt
parsonsmatt approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will release today

yesod-static/test/EmbedProductionTest.hs
Comment on lines +126 to +129
lookup "Content-Type" (simpleHeaders resp) `elem`
[ Just "text/javascript" -- mime-types >= 0.1.2.1
, Just "application/javascript" -- mime-types <= 0.1.2.0
]
Copy link
Contributor

@parsonsmatt parsonsmatt Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@parsonsmatt
Copy link
Contributor

parsonsmatt commented Jan 20, 2026

idc about windows ci being broken tbqh

@parsonsmatt parsonsmatt merged commit 5466dc3 into yesodweb:master Jan 20, 2026
12 of 13 checks passed
@sternenseemann sternenseemann deleted the yesod-static-mime-types-0.1.2.1 branch January 21, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parsonsmatt parsonsmatt parsonsmatt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

yesod-static testcase failed in Stackage LTS

3 participants

@sternenseemann @parsonsmatt @psibi